linux-kernel - Re: linux-6.18-rc2/arch/arm64/kvm/vgic/vgic-v3.c:728: Possible || and

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <86o6q1wz45.wl-maz@kernel.org>
Date: Mon, 20 Oct 2025 13:12:42 +0100
From: Marc Zyngier <maz@...nel.org>
To: David Binderman <dcb314@...mail.com>
Cc: "oliver.upton@...ux.dev"
	<oliver.upton@...ux.dev>,
	"joey.gouly@....com" <joey.gouly@....com>,
	"suzuki.poulose@....com" <suzuki.poulose@....com>,
	"yuzenghui@...wei.com"
	<yuzenghui@...wei.com>,
	"catalin.marinas@....com" <catalin.marinas@....com>,
	"will@...nel.org" <will@...nel.org>,
	"linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>,
	"kvmarm@...ts.linux.dev"
	<kvmarm@...ts.linux.dev>,
	LKML <linux-kernel@...r.kernel.org>
Subject: Re: linux-6.18-rc2/arch/arm64/kvm/vgic/vgic-v3.c:728: Possible || and | mixup ?

On Mon, 20 Oct 2025 12:12:33 +0100,
David Binderman <dcb314@...mail.com> wrote:
> 
> Hello there,
> 
> Static analyser cppcheck said:
> 
> linux-6.18-rc2/arch/arm64/kvm/vgic/vgic-v3.c:728:48: style: inconclusive: Boolean expression 'common_trap' is used in bitwise operation. Did you mean '||'? [bitwiseOnBoolean]
> 
> Source code is
> 
>     if (group0_trap || group1_trap || common_trap | dir_trap) {
> 
> Maybe better code:
> 
>     if (group0_trap || group1_trap || common_trap || dir_trap) {
> 

Sure. please send in a patch.

	M.

-- 
Without deviation from the norm, progress is not possible.