linux-kernel - [PATCH] media: i2c: imx290: Omit a variable reassignment in imx290

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <27dd84dd-a4e2-47f3-813a-1d4e4b0117ee@web.de>
Date: Mon, 20 Oct 2025 14:18:37 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: linux-media@...r.kernel.org, Benjamin Bara <benjamin.bara@...data.com>,
 Manivannan Sadhasivam <mani@...nel.org>,
 Mauro Carvalho Chehab <mchehab@...nel.org>,
 Sakari Ailus <sakari.ailus@...ux.intel.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: [PATCH] media: i2c: imx290: Omit a variable reassignment in
 imx290_probe()

From: Markus Elfring <elfring@...rs.sourceforge.net>
Date: Mon, 20 Oct 2025 14:10:20 +0200

An error code was assigned to a variable and checked accordingly.
This value was passed to a dev_err_probe() call in an if branch.
This function is documented in the way that the same value is returned.
Thus delete a redundant variable reassignment.

The source code was transformed by using the Coccinelle software.

Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
---
 drivers/media/i2c/imx290.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
index 21cbc81cb2ed..9623a9c21c9d 100644
--- a/drivers/media/i2c/imx290.c
+++ b/drivers/media/i2c/imx290.c
@@ -1633,7 +1633,7 @@ static int imx290_probe(struct i2c_client *client)
 	 */
 	ret = imx290_stop_streaming(imx290);
 	if (ret) {
-		ret = dev_err_probe(dev, ret, "Could not initialize device\n");
+		dev_err_probe(dev, ret, "Could not initialize device\n");
 		goto err_pm;
 	}
 
-- 
2.51.1