linux-kernel - Re: [PATCH v7.1 0/4] bitfield initial refactor within nova-core (RESEND)

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-Id: <DDO1O4XLJVHR.1642YK4GK85CT@nvidia.com>
Date: Tue, 21 Oct 2025 22:46:01 +0900
From: "Alexandre Courbot" <acourbot@...dia.com>
To: "Danilo Krummrich" <dakr@...nel.org>, "Alexandre Courbot"
 <acourbot@...dia.com>
Cc: "Joel Fernandes" <joelagnelf@...dia.com>,
 <linux-kernel@...r.kernel.org>, <rust-for-linux@...r.kernel.org>,
 <dri-devel@...ts.freedesktop.org>, "Alistair Popple" <apopple@...dia.com>,
 "Miguel Ojeda" <ojeda@...nel.org>, "Alex Gaynor" <alex.gaynor@...il.com>,
 "Boqun Feng" <boqun.feng@...il.com>, "Gary Guo" <gary@...yguo.net>,
 <bjorn3_gh@...tonmail.com>, "Benno Lossin" <lossin@...nel.org>, "Andreas
 Hindborg" <a.hindborg@...nel.org>, "Alice Ryhl" <aliceryhl@...gle.com>,
 "Trevor Gross" <tmgross@...ch.edu>, "David Airlie" <airlied@...il.com>,
 "Simona Vetter" <simona@...ll.ch>, "Maarten Lankhorst"
 <maarten.lankhorst@...ux.intel.com>, "Maxime Ripard" <mripard@...nel.org>,
 "Thomas Zimmermann" <tzimmermann@...e.de>, "John Hubbard"
 <jhubbard@...dia.com>, "Timur Tabi" <ttabi@...dia.com>,
 <joel@...lfernandes.org>, "Elle Rhumsaa" <elle@...thered-steel.dev>, "Yury
 Norov" <yury.norov@...il.com>, "Daniel Almeida"
 <daniel.almeida@...labora.com>, <nouveau@...ts.freedesktop.org>
Subject: Re: [PATCH v7.1 0/4] bitfield initial refactor within nova-core
 (RESEND)

On Tue Oct 21, 2025 at 8:44 AM JST, Danilo Krummrich wrote:
> On 10/18/25 3:41 PM, Alexandre Courbot wrote:
>> On Fri Oct 17, 2025 at 12:13 AM JST, Joel Fernandes wrote:
>>> (Resending due to some commit message mistakes (missing SOB etc). Thanks!).
>>>
>>> These patches implement the initial refactoring and few improvements to the
>>> register and bitfield macros. Rebased on drm-rust-next.
>>>
>>> Main difference from the previous series [1] is dropped the moving out of
>>> nova-core pending BoundedInt changes:
>>> https://lore.kernel.org/all/20251003154748.1687160-1-joelagnelf@nvidia.com/
>>> Other than that, added tags, resolved conflict with kernel::fmt changes and
>>> rebased on drm-rust-next.
>> 
>> Thanks, this version is looking pretty good, and works as intended.
>> 
>> I plan on pushing these 4 patches soonish after fixing the line length
>> issues and the other few problems reported by checkpatch.
>> 
>> Danilo, please let me know if you think this is premature, but imho it
>> is good to set this part in stone to avoid merge conflicts with future
>> patches that will want to modify the register macro.
>
> SGTM, we can keep discussing the hi:lo ascending / descending topic for
> nova-core independently.
>
> However, for the sample code that, eventually, we'll move out of nova-core, we
> should stick to what's common.
>
> With that,
>
> Acked-by: Danilo Krummrich <dakr@...nel.org>

Pushed to drm-rust-next after fixing the checkpatch errors and
reordering the sample code in descending order.

... and as dim was pushing, I noticed I forgot to add your Acked-by. >_<
Apologies for that.