linux-kernel - Re: [PATCH] leds: leds-lp50xx: LP5009 supports 3 modules for a total of 9 LEDs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021150642.GJ475031@google.com>
Date: Tue, 21 Oct 2025 16:06:42 +0100
From: Lee Jones <lee@...nel.org>
To: Christian Hitz <christian@...rinett.li>
Cc: Pavel Machek <pavel@...nel.org>, Christian Hitz <christian.hitz@....ch>,
	stable@...r.kernel.org, linux-leds@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH] leds: leds-lp50xx: LP5009 supports 3 modules for a total
 of 9 LEDs

On Wed, 08 Oct 2025, Christian Hitz wrote:

> From: Christian Hitz <christian.hitz@....ch>

You need forthcoming and insightful commit message.

> Signed-off-by: Christian Hitz <christian.hitz@....ch>
> Cc: stable@...r.kernel.org

Fine, but place this above your SoB.

> ---
>  drivers/leds/leds-lp50xx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/leds/leds-lp50xx.c b/drivers/leds/leds-lp50xx.c
> index 94f8ef6b482c..05229e2f2e7e 100644
> --- a/drivers/leds/leds-lp50xx.c
> +++ b/drivers/leds/leds-lp50xx.c
> @@ -54,7 +54,7 @@
>  /* There are 3 LED outputs per bank */
>  #define LP50XX_LEDS_PER_MODULE	3
>  
> -#define LP5009_MAX_LED_MODULES	2
> +#define LP5009_MAX_LED_MODULES	3
>  #define LP5012_MAX_LED_MODULES	4
>  #define LP5018_MAX_LED_MODULES	6
>  #define LP5024_MAX_LED_MODULES	8
> -- 
> 2.51.0
> 

-- 
Lee Jones [李琼斯]