linux-kernel - Re: [PATCH v4 5/5] irqchip/gic-its: Rework platform MSI deviceID detection

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <868qh4wak4.wl-maz@kernel.org>
Date: Tue, 21 Oct 2025 16:15:23 +0100
From: Marc Zyngier <maz@...nel.org>
To: Lorenzo Pieralisi <lpieralisi@...nel.org>
Cc: linux-kernel@...r.kernel.org,	linux-arm-kernel@...ts.infradead.org,
	devicetree@...r.kernel.org,	linux-pci@...r.kernel.org,	Frank Li
 <Frank.Li@....com>,	Sascha Bischoff <sascha.bischoff@....com>,	Thomas
 Gleixner <tglx@...utronix.de>,	Rob Herring <robh@...nel.org>,	Scott Branden
 <sbranden@...adcom.com>,	Bjorn Helgaas <bhelgaas@...gle.com>,	Ray Jui
 <rjui@...adcom.com>,	Manivannan Sadhasivam <mani@...nel.org>,	Krzysztof
 Wilczyński <kwilczynski@...nel.org>
Subject: Re: [PATCH v4 5/5] irqchip/gic-its: Rework platform MSI deviceID detection

On Tue, 21 Oct 2025 13:41:03 +0100,
Lorenzo Pieralisi <lpieralisi@...nel.org> wrote:
> 
> Current code retrieving platform devices MSI devID in the GIC ITS MSI
> parent helpers suffers from some minor issues:
> 
> - It leaks a struct device_node reference
> - It is duplicated between GICv3 and GICv5 for no good reason
> - It does not use the OF phandle iterator code that simplifies
>   the msi-parent property parsing
> 
> Consolidate GIC v3 and v5 deviceID retrieval in a function that addresses
> the full set of issues in one go by merging GIC v3 and v5 code and
> converting the msi-parent parsing loop to the more modern OF phandle
> iterator API, fixing the struct device_node reference leak in the process.
> 
> Signed-off-by: Lorenzo Pieralisi <lpieralisi@...nel.org>
> Reviewed-by: Frank Li <Frank.Li@....com>
> Cc: Sascha Bischoff <sascha.bischoff@....com>
> Cc: Thomas Gleixner <tglx@...utronix.de>
> Cc: Rob Herring <robh@...nel.org>
> Cc: Frank Li <Frank.Li@....com>
> Cc: Marc Zyngier <maz@...nel.org>
> ---
>  drivers/irqchip/irq-gic-its-msi-parent.c | 91 ++++++------------------
>  1 file changed, 23 insertions(+), 68 deletions(-)

Reviewed-by: Marc Zyngier <maz@...nel.org>

	M.

-- 
Without deviation from the norm, progress is not possible.