linux-kernel - Re: [PATCH mm-new 1/1] mm/khugepaged: Factor out common logic in [scan,alloc]_sleep_millisecs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d36c0e8d-386b-444c-bd6c-ec9439778e96@linux.dev>
Date: Tue, 21 Oct 2025 10:14:56 +0800
From: Lance Yang <lance.yang@...ux.dev>
To: Leon Hwang <leon.hwang@...ux.dev>
Cc: ziy@...dia.com, baolin.wang@...ux.alibaba.com, david@...hat.com,
 Liam.Howlett@...cle.com, npache@...hat.com, ryan.roberts@....com,
 dev.jain@....com, baohua@...nel.org, linux-mm@...ck.org,
 akpm@...ux-foundation.org, linux-kernel@...r.kernel.org,
 lorenzo.stoakes@...cle.com
Subject: Re: [PATCH mm-new 1/1] mm/khugepaged: Factor out common logic in
 [scan,alloc]_sleep_millisecs_store()



On 2025/10/20 19:53, Leon Hwang wrote:
> Both scan_sleep_millisecs_store() and alloc_sleep_millisecs_store()
> perform the same operations: parse the input value, update their
> respective sleep interval, reset khugepaged_sleep_expire, and wake up
> the khugepaged thread.
> 
> Factor out this duplicated logic into a helper function
> __sleep_millisecs_store(), and simplify both store functions.

Thanks, less is more ;)

> 
> No functional change intended.
> 
> Signed-off-by: Leon Hwang <leon.hwang@...ux.dev>
> ---

After tweaking as Lorenzo suggested, LGTM.

Reviewed-by: Lance Yang <lance.yang@...ux.dev>