linux-kernel - Re: [PATCH] mm/vmstat: Fix indentation in fold

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <bx5zarozwnlogznjai2242und55z5jxs4bpgliswuo7shezbma@ri2ocyj7n4q7>
Date: Tue, 21 Oct 2025 12:10:14 -0400
From: "Liam R. Howlett" <Liam.Howlett@...cle.com>
To: Vlastimil Babka <vbabka@...e.cz>
Cc: akpm@...ux-foundation.org, david@...hat.com, lorenzo.stoakes@...cle.com,
        rppt@...nel.org, surenb@...gle.com, mhocko@...e.com,
        linux-mm@...ck.org, linux-kernel@...r.kernel.org,
        jinnasujing@...il.com
Subject: Re: [PATCH] mm/vmstat: Fix indentation in fold_diff function.

* Vlastimil Babka <vbabka@...e.cz> [251021 05:03]:
> On 10/21/25 09:37, Jing Su wrote:
> > Adjust misaligned braces in the fold_diff function to improve
> > code readability and maintain consistent coding style.
> > 
> > Signed-off-by: Jing Su <jingsusu@...iglobal.com>
> > ---
> >  mm/vmstat.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> > 
> > diff --git a/mm/vmstat.c b/mm/vmstat.c
> > index bb09c032eecf..63860c3d22e6 100644
> > --- a/mm/vmstat.c
> > +++ b/mm/vmstat.c
> > @@ -782,13 +782,13 @@ static int fold_diff(int *zone_diff, int *node_diff)
> >  		if (zone_diff[i]) {
> >  			atomic_long_add(zone_diff[i], &vm_zone_stat[i]);
> >  			changes++;
> > -	}
> > +		}
> >  
> >  	for (i = 0; i < NR_VM_NODE_STAT_ITEMS; i++)
> >  		if (node_diff[i]) {
> >  			atomic_long_add(node_diff[i], &vm_node_stat[i]);
> >  			changes++;
> > -	}
> > +		}
> >  	return changes;
> >  }
> 
> Thanks. IMHO it would be even more readable if the for () also had {
> }brackets.

Yes, I agree.  That's probably how this happened in the first place.