linux-kernel - [PATCH] RDMA/mlx5: Fix refcount inconsistency in mlx5_netdev

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <aPe3mnFjQeXaILyR@chcpu18>
Date: Tue, 21 Oct 2025 16:40:58 +0000
From: Shuhao Fu <sfual@....ust.hk>
To: Leon Romanovsky <leon@...nel.org>, Jason Gunthorpe <jgg@...pe.ca>
Cc: linux-rdma@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: [PATCH] RDMA/mlx5: Fix refcount inconsistency in mlx5_netdev_event

Fix refcount inconsistency related to `mlx5_ib_get_native_port_mdev`.

Function `mlx5_ib_get_native_port_mdev` could increase the counter of 
`mpi->mdev_refcnt` if mpi is not master. To ensure refcount consistency,
each call to `mlx5_ib_get_native_port_mdev` should have a corresponding
call to `mlx5_ib_put_native_port_mdev`. In `mlx5_netdev_event`, two
branches fail to do so, leading to a possible bug when unbinding.

Fixes: 379013776222 ("RDMA/mlx5: Handle link status event only for LAG device")
Fixes: 35b0aa67b298 ("RDMA/mlx5: Refactor netdev affinity code")
Signed-off-by: Shuhao Fu <sfual@....ust.hk>
---
 drivers/infiniband/hw/mlx5/main.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/infiniband/hw/mlx5/main.c b/drivers/infiniband/hw/mlx5/main.c
index fc1e86f6c..0c4aa7c50 100644
--- a/drivers/infiniband/hw/mlx5/main.c
+++ b/drivers/infiniband/hw/mlx5/main.c
@@ -247,7 +247,7 @@ static int mlx5_netdev_event(struct notifier_block *this,
 
 		if (!netif_is_lag_master(ndev) && !netif_is_lag_port(ndev) &&
 		    !mlx5_core_mp_enabled(mdev))
-			return NOTIFY_DONE;
+			goto done;
 
 		if (mlx5_lag_is_roce(mdev) || mlx5_lag_is_sriov(mdev)) {
 			struct net_device *lag_ndev;
@@ -268,7 +268,7 @@ static int mlx5_netdev_event(struct notifier_block *this,
 		if (ibdev->is_rep)
 			roce = mlx5_get_rep_roce(ibdev, ndev, upper, &port_num);
 		if (!roce)
-			return NOTIFY_DONE;
+			goto done;
 
 		ib_ndev = ib_device_get_netdev(&ibdev->ib_dev, port_num);
 
-- 
2.39.5 (Apple Git-154)