linux-kernel - Re: [PATCH 09/12] unwind: Make unwind_task_info::unwind

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020102012.GM3419281@noisy.programming.kicks-ass.net>
Date: Mon, 20 Oct 2025 12:20:12 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Steven Rostedt <rostedt@...dmis.org>
Cc: jpoimboe@...nel.org, rostedt@...nel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 09/12] unwind: Make unwind_task_info::unwind_mask
 consistent

On Wed, Oct 01, 2025 at 11:47:02AM -0400, Steven Rostedt wrote:
> On Wed, 24 Sep 2025 09:59:57 +0200
> Peter Zijlstra <peterz@...radead.org> wrote:
> 
> > @@ -324,7 +324,8 @@ void unwind_deferred_cancel(struct unwin
> >  	guard(rcu)();
> >  	/* Clear this bit from all threads */
> >  	for_each_process_thread(g, t) {
> > -		clear_bit(bit, &t->unwind_info.unwind_mask);
> > +		atomic_long_andnot(UNWIND_USED,
> > +				   &t->unwind_info.unwind_mask);
> 
> Shouldn't this be:
> 
> 		atomic_long_andnot(BIT(bit), &t->unwind_info.unwind_mask);
> 
>  ?
> 

Yeah, copy-pasta failure there. Thanks!