linux-kernel - Re: [PATCH] objtool: fix failure when being compiled on x32 system

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251020123835.GE4067720@noisy.programming.kicks-ass.net>
Date: Mon, 20 Oct 2025 14:38:35 +0200
From: Peter Zijlstra <peterz@...radead.org>
To: Mikulas Patocka <mpatocka@...hat.com>
Cc: Ard Biesheuvel <ardb@...nel.org>, Borislav Petkov <bp@...en8.de>,
	Josh Poimboeuf <jpoimboe@...nel.org>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] objtool: fix failure when being compiled on x32 system

On Mon, Oct 20, 2025 at 02:23:58PM +0200, Mikulas Patocka wrote:
> Fix compilation failure when compiling the kernel with the x32 toolchain.
> 
> In file included from check.c:16:
> check.c: In function ‘check_abs_references’:
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:47:17: error: format ‘%lx’ expects argument of type ‘long unsigned int’, but argument 7 has type ‘u64’ {aka ‘long
> long unsigned int’} [-Werror=format=]
>    47 |                 "%s%s%s: objtool" extra ": " format "\n",               \
>       |                 ^~~~~~~~~~~~~~~~~
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:54:9: note: in expansion of macro ‘___WARN’
>    54 |         ___WARN(severity, "", format, ##__VA_ARGS__)
>       |         ^~~~~~~
> /usr/src/git/linux-2.6/tools/objtool/include/objtool/warn.h:74:27: note: in expansion of macro ‘__WARN’
>    74 | #define WARN(format, ...) __WARN(WARN_STR, format, ##__VA_ARGS__)
>       |                           ^~~~~~
> check.c:4713:33: note: in expansion of macro ‘WARN’
>  4713 |                                 WARN("section %s has absolute relocation at offset 0x%lx",
>       |                                 ^~~~
> 
> Signed-off-by: Mikulas Patocka <mpatocka@...hat.com>
> Fixes: 0d6e4563fc03 ("objtool: Add action to check for absence of absolute relocations")

You could've kept Ard's Ack. I'll go add it manually.

Thanks!