linux-kernel - RE: [PATCH v3 2/3] mm: Change ghes code to allow poison of non-struct pfn

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <SJ1PR11MB6083BF0885BC19E715C1A96EFCF2A@SJ1PR11MB6083.namprd11.prod.outlook.com>
Date: Tue, 21 Oct 2025 17:19:13 +0000
From: "Luck, Tony" <tony.luck@...el.com>
To: "Weiny, Ira" <ira.weiny@...el.com>, "ankita@...dia.com"
	<ankita@...dia.com>, "aniketa@...dia.com" <aniketa@...dia.com>, "Sethi,
 Vikram" <vsethi@...dia.com>, "jgg@...dia.com" <jgg@...dia.com>,
	"mochs@...dia.com" <mochs@...dia.com>, "skolothumtho@...dia.com"
	<skolothumtho@...dia.com>, "linmiaohe@...wei.com" <linmiaohe@...wei.com>,
	"nao.horiguchi@...il.com" <nao.horiguchi@...il.com>,
	"akpm@...ux-foundation.org" <akpm@...ux-foundation.org>, "david@...hat.com"
	<david@...hat.com>, "lorenzo.stoakes@...cle.com"
	<lorenzo.stoakes@...cle.com>, "Liam.Howlett@...cle.com"
	<Liam.Howlett@...cle.com>, "vbabka@...e.cz" <vbabka@...e.cz>,
	"rppt@...nel.org" <rppt@...nel.org>, "surenb@...gle.com" <surenb@...gle.com>,
	"mhocko@...e.com" <mhocko@...e.com>, "bp@...en8.de" <bp@...en8.de>,
	"rafael@...nel.org" <rafael@...nel.org>, "guohanjun@...wei.com"
	<guohanjun@...wei.com>, "mchehab@...nel.org" <mchehab@...nel.org>,
	"lenb@...nel.org" <lenb@...nel.org>, "Tian, Kevin" <kevin.tian@...el.com>,
	"alex@...zbot.org" <alex@...zbot.org>
CC: "cjia@...dia.com" <cjia@...dia.com>, "kwankhede@...dia.com"
	<kwankhede@...dia.com>, "targupta@...dia.com" <targupta@...dia.com>,
	"zhiw@...dia.com" <zhiw@...dia.com>, "dnigam@...dia.com" <dnigam@...dia.com>,
	"kjaju@...dia.com" <kjaju@...dia.com>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "linux-mm@...ck.org" <linux-mm@...ck.org>,
	"linux-edac@...r.kernel.org" <linux-edac@...r.kernel.org>,
	"Jonathan.Cameron@...wei.com" <Jonathan.Cameron@...wei.com>,
	"Smita.KoralahalliChannabasappa@....com"
	<Smita.KoralahalliChannabasappa@....com>, "u.kleine-koenig@...libre.com"
	<u.kleine-koenig@...libre.com>, "peterz@...radead.org"
	<peterz@...radead.org>, "linux-acpi@...r.kernel.org"
	<linux-acpi@...r.kernel.org>, "kvm@...r.kernel.org" <kvm@...r.kernel.org>
Subject: RE: [PATCH v3 2/3] mm: Change ghes code to allow poison of non-struct
 pfn

> >     pfn = PHYS_PFN(physical_addr);
> > -   if (!pfn_valid(pfn) && !arch_is_platform_page(physical_addr)) {
>
> Tony,
>
> I'm not an SGX expert but does this break SGX by removing
> arch_is_platform_page()?
>
> See:
>
> 40e0e7843e23 ("x86/sgx: Add infrastructure to identify SGX EPC pages")
> Cc: Tony Luck <tony.luck@...el.com>
>
Ira,

I think this deletion makes the GHES code always call memory_failure()
instead of bailing out here on "bad" page frame numbers.

That centralizes the checks for different types of memory into
memory_failure().

-Tony