linux-kernel - Re: [PATCH v3] tools/dma: move dma_map_benchmark from selftests to tools/dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CAGsJ_4zF4JOPXpkzmR+invqefLstcaB=xaGEfueHEQRSg2oLOg@mail.gmail.com>
Date: Tue, 21 Oct 2025 15:59:05 +1300
From: Barry Song <21cnbao@...il.com>
To: Qinxin Xia <xiaqinxin@...wei.com>
Cc: m.szyprowski@...sung.com, robin.murphy@....com, prime.zeng@...wei.com, 
	fanghao11@...wei.com, linux-kernel@...r.kernel.org, linuxarm@...wei.com, 
	wangzhou1@...ilicon.com
Subject: Re: [PATCH v3] tools/dma: move dma_map_benchmark from selftests to tools/dma

> @@ -0,0 +1,2 @@
> +# SPDX-License-Identifier: GPL-2.0-only
> +dma_map_benchmark
> diff --git a/tools/dma/Makefile b/tools/dma/Makefile
> new file mode 100644
> index 000000000000..4acbd9e00cfa
> --- /dev/null
> +++ b/tools/dma/Makefile
> @@ -0,0 +1,17 @@
> +# SPDX-License-Identifier: GPL-2.0
> +bindir ?= /usr/bin
> +
> +CFLAGS += -idirafter../../include/uapi

I'm a bit confused — it seems you haven’t tried to understand what the issue
was in v1 [1]. You were using -I for kernel header files (under
include/linux but not uapi), which caused those kernel headers to take
precedence over the system headers, leading to build errors. The uapi
headers, however, are specifically designed to be installed into the system by
the toolchain.
So that’s no longer the case — -idirafter is not the correct flag for uapi.

> index b12f1f9babf8..5474a450863c 100644
> --- a/tools/testing/selftests/dma/dma_map_benchmark.c
> +++ b/tools/dma/dma_map_benchmark.c
> @@ -10,7 +10,6 @@
>  #include <unistd.h>
>  #include <sys/ioctl.h>
>  #include <sys/mman.h>
> -#include <linux/types.h>

What’s the reason for this? Is it to work around a build error?
If so, no — please keep it.

>  #include <linux/map_benchmark.h>

Thanks
Barry