linux-kernel - Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers automatic module loading

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <42f11845-35f2-40e0-b860-c25ba6f8d503@sirena.org.uk>
Date: Tue, 21 Oct 2025 20:00:13 +0100
From: Mark Brown <broonie@...nel.org>
To: Alexander Sverdlin <alexander.sverdlin@...il.com>
Cc: Javier Martinez Canillas <javierm@...hat.com>,
	Wolfram Sang <wsa@...-dreams.de>,
	Herve Codina <herve.codina@...tlin.com>,
	David Rhodes <david.rhodes@...rus.com>,
	Richard Fitzgerald <rf@...nsource.cirrus.com>,
	Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Nikita Shubin <nikita.shubin@...uefel.me>,
	Axel Lin <axel.lin@...ics.com>,
	Brian Austin <brian.austin@...rus.com>, linux-sound@...r.kernel.org,
	patches@...nsource.cirrus.com, devicetree@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@...tlin.com>
Subject: Re: [PATCH 1/3] ASoC: cs4271: Fix cs4271 I2C and SPI drivers
 automatic module loading

On Fri, Oct 17, 2025 at 08:14:43PM +0200, Alexander Sverdlin wrote:

> "Reparing" them as Herve proposed would result in I2C modules being
> loaded only via "of:" style modalias and SPI still via "spi:". Which
> sounds all but consistent.

> If SPI ever adopts the same of_device_uevent_modalias(), both backends
> would require "of:" prefixed modalias, and it will not be possible to
> load the proper one for the corresponding bus type.

> What are your thoughs on this?

Or at least you'd get both modules loaded with one being redundant.  TBH
I'm very reluctant to touch this stuff for SPI without some very careful
analysis that it's not going to cause things to explode on people, right
now things seem to be working well enough so I'm not clear we'd be
solving an actual problem.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)