linux-kernel - Re: [PATCH v2 1/4] arm64/sysreg: Fix checks for incomplete sysreg definitions

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <0ec40909-7ac7-4e55-931a-ad51a2e39726@sirena.org.uk>
Date: Tue, 21 Oct 2025 20:04:10 +0100
From: Mark Brown <broonie@...nel.org>
To: Sascha Bischoff <Sascha.Bischoff@....com>
Cc: "linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"kvmarm@...ts.linux.dev" <kvmarm@...ts.linux.dev>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"kvm@...r.kernel.org" <kvm@...r.kernel.org>, nd <nd@....com>,
	Mark Rutland <Mark.Rutland@....com>,
	Catalin Marinas <Catalin.Marinas@....com>,
	"maz@...nel.org" <maz@...nel.org>,
	"oliver.upton@...ux.dev" <oliver.upton@...ux.dev>,
	Joey Gouly <Joey.Gouly@....com>,
	Suzuki Poulose <Suzuki.Poulose@....com>,
	"yuzenghui@...wei.com" <yuzenghui@...wei.com>,
	"will@...nel.org" <will@...nel.org>,
	"lpieralisi@...nel.org" <lpieralisi@...nel.org>
Subject: Re: [PATCH v2 1/4] arm64/sysreg: Fix checks for incomplete sysreg
 definitions

On Thu, Oct 09, 2025 at 04:54:47PM +0000, Sascha Bischoff wrote:
> The checks for incomplete sysreg definitions were checking if the
> next_bit was greater than 0, which is incorrect and missed occasions
> where bit 0 hasn't been defined for a sysreg. The reason is that
> next_bit is -1 when all bits have been processed (LSB - 1).

Reviewed-by: Mark Brown <broonie@...nel.org>

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)