linux-kernel - [PATCH 4/4] wifi: mac80211_hwsim: use more restrictive permissions on debugfs files

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <f0609c73741321798da9baf7016270374d8e20fb.1761078139.git.amoldhamale1105@gmail.com>
Date: Tue, 21 Oct 2025 20:50:26 +0000
From: Amol Dhamale <amoldhamale1105@...il.com>
To: johannes@...solutions.net
Cc: linux-wireless@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	sriram.g@...t.com,
	Amol Dhamale <amoldhamale1105@...il.com>
Subject: [PATCH 4/4] wifi: mac80211_hwsim: use more restrictive permissions on debugfs files

Adhere to Linux kernel coding style.

Reported by checkpatch:

ERROR: Exporting writable files is usually an error. Consider more restrictive permissions.

Signed-off-by: Amol Dhamale <amoldhamale1105@...il.com>
---
 drivers/net/wireless/virtual/mac80211_hwsim.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/net/wireless/virtual/mac80211_hwsim.c b/drivers/net/wireless/virtual/mac80211_hwsim.c
index e62d4a98671f..7b206a4d57b6 100644
--- a/drivers/net/wireless/virtual/mac80211_hwsim.c
+++ b/drivers/net/wireless/virtual/mac80211_hwsim.c
@@ -5816,10 +5816,10 @@ static int mac80211_hwsim_new_radio(struct genl_info *info,
 	}
 
 	data->debugfs = debugfs_create_dir("hwsim", hw->wiphy->debugfsdir);
-	debugfs_create_file("ps", 0666, data->debugfs, data, &hwsim_fops_ps);
-	debugfs_create_file("group", 0666, data->debugfs, data,
+	debugfs_create_file("ps", 0644, data->debugfs, data, &hwsim_fops_ps);
+	debugfs_create_file("group", 0644, data->debugfs, data,
 			    &hwsim_fops_group);
-	debugfs_create_file("rx_rssi", 0666, data->debugfs, data,
+	debugfs_create_file("rx_rssi", 0644, data->debugfs, data,
 			    &hwsim_fops_rx_rssi);
 	if (!data->use_chanctx)
 		debugfs_create_file("dfs_simulate_radar", 0222,
-- 
2.43.0