[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-Id: <20251021135553.811b77539d2d41fff3c3b992@linux-foundation.org>
Date: Tue, 21 Oct 2025 13:55:53 -0700
From: Andrew Morton <akpm@...ux-foundation.org>
To: Doug Anderson <dianders@...omium.org>
Cc: linux-kernel@...r.kernel.org, Andrew Chant <achant@...gle.com>,
Alexander Shishkin <alexander.shishkin@...ux.intel.com>, Brian Gerst
<brgerst@...il.com>, Christian Brauner <brauner@...nel.org>, Francesco
Valla <francesco@...la.it>, Geert Uytterhoeven <geert+renesas@...der.be>,
Guo Weikang <guoweikang.kernel@...il.com>, Huacai Chen
<chenhuacai@...nel.org>, Jan Hendrik Farr <kernel@...rr.cc>, Jeff Xu
<jeffxu@...omium.org>, Kees Cook <kees@...nel.org>, Masahiro Yamada
<masahiroy@...nel.org>, Michal Koutný
<mkoutny@...e.com>, Miguel Ojeda <ojeda@...nel.org>,
"Mike Rapoport (Microsoft)" <rppt@...nel.org>, Nathan Chancellor
<nathan@...nel.org>, Peter Zijlstra <peterz@...radead.org>, Randy Dunlap
<rdunlap@...radead.org>, Shakeel Butt <shakeel.butt@...ux.dev>, Tejun Heo
<tj@...nel.org>, Thomas Gleixner <tglx@...utronix.de>, Thomas
Weißschuh <thomas.weissschuh@...utronix.de>,
"Uladzislau Rezki (Sony)" <urezki@...il.com>
Subject: Re: [PATCH] init/main.c: Wrap long kernel cmdline when printing to
logs
On Mon, 20 Oct 2025 13:00:22 -0700 Doug Anderson <dianders@...omium.org> wrote:
> > And the code would presumably be much simpler if we simply chunked up
> > the printing and spat out one really long line.
>
> I'm not quite sure what you're suggesting. Before my changes we _do_
> try to spit out one really long line, but then printk() silently
> truncates it for us at 1021 characters. Re-reading your suggestion,
> I'm not sure if you're suggesting that we improve printk() to handle
> lines longer than 1021 characters by chunking them up, or if you're
> suggesting that this code could use "pr_cont()" to chunk things up.
> ...or something totally different. ;-) Can you clarify?
I was suggsting the latter - emit these really long lines via repeated
calls to printk().
Powered by blists - more mailing lists