linux-kernel - Re: [PATCH] usb: dwc3: qcom: Omit a variable reassignment in dwc3_qcom

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021221804.yixk2wqyttcfwqqr@synopsys.com>
Date: Tue, 21 Oct 2025 22:18:07 +0000
From: Thinh Nguyen <Thinh.Nguyen@...opsys.com>
To: Markus Elfring <Markus.Elfring@....de>
CC: "linux-usb@...r.kernel.org" <linux-usb@...r.kernel.org>,
        "linux-arm-msm@...r.kernel.org" <linux-arm-msm@...r.kernel.org>,
        Bjorn Andersson <bjorn.andersson@....qualcomm.com>,
        Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
        Neil Armstrong <neil.armstrong@...aro.org>,
        Thinh Nguyen <Thinh.Nguyen@...opsys.com>,
        "kernel-janitors@...r.kernel.org" <kernel-janitors@...r.kernel.org>,
        LKML <linux-kernel@...r.kernel.org>,
        Anand Moon <linux.amoon@...il.com>,
        Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] usb: dwc3: qcom: Omit a variable reassignment in
 dwc3_qcom_probe()

On Mon, Oct 20, 2025, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 20 Oct 2025 17:17:18 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete a redundant variable reassignment.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>  drivers/usb/dwc3/dwc3-qcom.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/dwc3/dwc3-qcom.c b/drivers/usb/dwc3/dwc3-qcom.c
> index ded2ca86670c..e81011ef130e 100644
> --- a/drivers/usb/dwc3/dwc3-qcom.c
> +++ b/drivers/usb/dwc3/dwc3-qcom.c
> @@ -707,6 +707,6 @@ static int dwc3_qcom_probe(struct platform_device *pdev)
>  	ret = dwc3_core_probe(&probe_data);
>  	if (ret)  {
> -		ret = dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
> +		dev_err_probe(dev, ret, "failed to register DWC3 Core\n");
>  		goto clk_disable;
>  	}
>  
> -- 
> 2.51.1
> 

Acked-by: Thinh Nguyen <Thinh.Nguyen@...opsys.com>

BR,
Thinh