[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <te5ubj3byqxfp7mivsmwpcfjdjb4sds5cjhybmibjiexjehswp@zbppl7syod24>
Date: Wed, 22 Oct 2025 01:23:58 +0300
From: Dmitry Baryshkov <dmitry.baryshkov@....qualcomm.com>
To: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
Cc: Bjorn Andersson <andersson@...nel.org>,
Konrad Dybcio <konradybcio@...nel.org>,
Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/4] regulator: rpmh-regulator: Fix PMIC5 BOB bypass
mode handling
On Wed, Oct 22, 2025 at 02:38:53AM +0530, Kamal Wadhwa wrote:
> Currently, when `rpmh_regulator_set_mode_bypass()` helper function
> is called to set bypass mode, it sends PMIC4's BOB bypass mode
> value for even if its a PMIC5 BOB.
>
> To fix this, introduce new hw_data parameters:
> - `bypass_supported` to check if bypass is supported.
> - `pmic_bypass_mode` to store bypass mode value.
>
> Use these 2 parameters to send correct PMIC bypass mode that
> corresponds to PMIC4/5 BOB regulators from the helper function.
>
> Signed-off-by: Kamal Wadhwa <kamal.wadhwa@....qualcomm.com>
Also missing the Fixes tag.
> ---
> drivers/regulator/qcom-rpmh-regulator.c | 18 +++++++++++++++---
> 1 file changed, 15 insertions(+), 3 deletions(-)
>
--
With best wishes
Dmitry
Powered by blists - more mailing lists