linux-kernel - Re: [PATCH] peci: controller: peci-aspeed: convert from round_rate() to determine

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4aa22124cefc6bd23d75bdb0d5a85a2f38c22a77.camel@codeconstruct.com.au>
Date: Wed, 22 Oct 2025 09:05:13 +1030
From: Andrew Jeffery <andrew@...econstruct.com.au>
To: "Winiarska, Iwona" <iwona.winiarska@...el.com>, 
 "gregkh@...uxfoundation.org"
	 <gregkh@...uxfoundation.org>, "bmasney@...hat.com" <bmasney@...hat.com>
Cc: "joel@....id.au" <joel@....id.au>, "linux-aspeed@...ts.ozlabs.org"
	 <linux-aspeed@...ts.ozlabs.org>, "sboyd@...nel.org" <sboyd@...nel.org>, 
 "linux-kernel@...r.kernel.org"
	 <linux-kernel@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	 <linux-arm-kernel@...ts.infradead.org>, "linux-clk@...r.kernel.org"
	 <linux-clk@...r.kernel.org>, "openbmc@...ts.ozlabs.org"
	 <openbmc@...ts.ozlabs.org>, "mripard@...nel.org" <mripard@...nel.org>
Subject: Re: [PATCH] peci: controller: peci-aspeed: convert from
 round_rate() to determine_rate()

On Tue, 2025-10-21 at 21:01 +0000, Winiarska, Iwona wrote:
> On Mon, 2025-10-20 at 09:30 +1030, Andrew Jeffery wrote:
> > On Fri, 2025-10-17 at 09:43 +0200, Greg Kroah-Hartman wrote:
> > > On Fri, Oct 17, 2025 at 05:57:44PM +1030, Andrew Jeffery wrote:
> > > > On Fri, 2025-10-17 at 08:41 +0200, Greg Kroah-Hartman wrote:
> > > > > On Fri, Oct 17, 2025 at 04:52:37PM +1030, Andrew Jeffery wrote:
> > > > > > Hi Greg,
> > > > > > 
> > > > > > On Thu, 2025-10-16 at 12:11 -0400, Brian Masney wrote:
> > > > > > > Hi Andrew and Iwona,
> > > > > > > 
> > > > > > > On Mon, Sep 15, 2025 at 02:36:48PM +0930, Andrew Jeffery wrote:
> > > > > > > > Hi Brian,
> > > > > > > > 
> > > > > > > > On Sun, 2025-09-14 at 07:56 -0400, Brian Masney wrote:
> > > > > > > > > Hi Iwona, Joel, and Andrew,
> > > > > > > > > 
> > > > > > > > > On Sun, Aug 10, 2025 at 06:21:51PM -0400, Brian Masney wrote:
> > > > > > > > > > The round_rate() clk ops is deprecated, so migrate this
> > > > > > > > > > driver from
> > > > > > > > > > round_rate() to determine_rate() using the Coccinelle
> > > > > > > > > > semantic patch
> > > > > > > > > > appended to the "under-the-cut" portion of the patch.
> > > > > > > > > > 
> > > > > > > > > > Signed-off-by: Brian Masney <bmasney@...hat.com>
> > > > > > > > > 
> > > > > > > > > Would it be possible to get this picked up for v6.18? I'd
> > > > > > > > > like to remove
> > > > > > > > > this API from drivers/clk in v6.19.
> > > > > > > > 
> > > > > > > > My (strong) preference is that Iwona applies it, but I'll keep
> > > > > > > > an eye
> > > > > > > > out for any unusual delays.
> > > > > > > 
> > > > > > > This patch wasn't picked up for v6.18. Any chance this can get
> > > > > > > picked up
> > > > > > > now for v6.19?
> > > > > > > 
> > > > > > > I'm hoping to get this merged so that we can remove the
> > > > > > > round_rate() clk
> > > > > > > op from the clk core. The clk maintainer (Stephen) mentioned this
> > > > > > > work
> > > > > > > in his last pull to Linus.
> > > > > > > 
> > > > > > > https://lore.kernel.org/linux-clk/20251007051720.11386-1-sboyd@kernel.org/
> > > > > > 
> > > > > > Are you happy to pick this up directly in Iwona's absence?
> > > > > 
> > > > > Why me?
> > > > 
> > > > I figured that would be sensible since Iwona historically sent you PRs
> > > > for the PECI subsystem.
> > > 
> > > I did not remember that, sorry.
> > > 
> > 
> > No worries.
> > 
> > >   The MAINTAINERS file does not mention
> > > this at all, and it lists many other maintainers that should be able to
> > > take this patch:
> > > 	$ ./scripts/get_maintainer.pl  drivers/peci/controller/peci-
> > > aspeed.c
> > > 	Iwona Winiarska <iwona.winiarska@...el.com> (maintainer:ASPEED PECI
> > > CONTROLLER)
> > > 	Joel Stanley <joel@....id.au> (maintainer:ARM/ASPEED MACHINE
> > > SUPPORT)
> > > 	Andrew Jeffery <andrew@...econstruct.com.au> (maintainer:ARM/ASPEED
> > > MACHINE SUPPORT)
> > 
> > Iwona currently appears unresponsive, as mentioned. Joel's stepped back
> > from maintaining the ASPEED bits as of earlier this year; I worked with
> > him to add myself as a maintainer there, hence the last entry, and now
> > getting in touch with you.
> > 
> > I can apply the patch and send you a PR if that helps, if Iwona doesn't
> > respond in the mean time.
> 
> Hi!
> 
> Sorry for the delay - for some reason this entire thread didn't land in my inbox
> and I just found it now, randomly browsing mailing list :/
> 
> I will sent it as a PR for v6.19.

Ah, super! Thanks Iwona.

Andrew