linux-kernel - Re: [PATCH V8 17/19] virtio_ring: factor out split indirect detaching logic

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACGkMEtV89bDjVhNV6=eZz7T0SLi6+17sn2ORNEnBbtifQxN1A@mail.gmail.com>
Date: Tue, 21 Oct 2025 11:55:47 +0800
From: Jason Wang <jasowang@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, 
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org
Subject: Re: [PATCH V8 17/19] virtio_ring: factor out split indirect detaching logic

On Tue, Oct 21, 2025 at 12:17 AM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Mon, Oct 20, 2025 at 03:10:01PM +0800, Jason Wang wrote:
> > Factor out the split indirect descriptor detaching logic in order to
> > allow it to be reused by the in order support.
> >
> > Acked-by: Eugenio Pérez <eperezma@...hat.com>
> > Reviewed-by: Xuan Zhuo <xuanzhuo@...ux.alibaba.com>
> > Signed-off-by: Jason Wang <jasowang@...hat.com>
> > ---
> >  drivers/virtio/virtio_ring.c | 63 ++++++++++++++++++++----------------
> >  1 file changed, 35 insertions(+), 28 deletions(-)
> >
> > diff --git a/drivers/virtio/virtio_ring.c b/drivers/virtio/virtio_ring.c
> > index c59e27e2ad68..0f07a6637acb 100644
> > --- a/drivers/virtio/virtio_ring.c
> > +++ b/drivers/virtio/virtio_ring.c
> > @@ -771,11 +771,42 @@ static bool virtqueue_kick_prepare_split(struct vring_virtqueue *vq)
> >       return needs_kick;
> >  }
> >
> > +static void detach_indirect_split(struct vring_virtqueue *vq,
> > +                               unsigned int head)
> > +{
> > +     struct vring_desc_extra *extra = vq->split.desc_extra;
> > +     struct vring_desc *indir_desc =
> > +            vq->split.desc_state[head].indir_desc;
>
> why split this line?  it's not too long.
>

Fixed.

Thanks