linux-kernel - Re: [PATCH 3/3] perf jevents: Suppress circular dependency warnings

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPcHk3yy0Q7jxK01@google.com>
Date: Tue, 21 Oct 2025 13:09:55 +0900
From: Namhyung Kim <namhyung@...nel.org>
To: James Clark <james.clark@...aro.org>
Cc: Peter Zijlstra <peterz@...radead.org>, Ingo Molnar <mingo@...hat.com>,
	Arnaldo Carvalho de Melo <acme@...nel.org>,
	Mark Rutland <mark.rutland@....com>,
	Alexander Shishkin <alexander.shishkin@...ux.intel.com>,
	Jiri Olsa <jolsa@...nel.org>, Ian Rogers <irogers@...gle.com>,
	Adrian Hunter <adrian.hunter@...el.com>, leo.yan@....com,
	linux-perf-users@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 3/3] perf jevents: Suppress circular dependency warnings

On Mon, Oct 20, 2025 at 05:08:28PM +0100, James Clark wrote:
> When doing an in source build, $(OUTPUT) is empty so the rule has the
> same input and output file. Suppress the warning by only adding the rule
> when doing an out of source build. The same condition already exists for
> the clean rule for json files.
> 
> This fixes the following warnings:
> 
>   make[3]: Circular pmu-events/arch/nds32/mapfile.csv <- pmu-events/arch/nds32/mapfile.csv dependency dropped.
>   make[3]: Circular pmu-events/arch/powerpc/mapfile.csv <- pmu-events/arch/powerpc/mapfile.csv dependency dropped.
>   ...

I noticed this too and confirm it's fixed by this change.

Tested-by: Namhyung Kim <namhyung@...nel.org>

Thanks,
Namhyung

> 
> Signed-off-by: James Clark <james.clark@...aro.org>
> ---
>  tools/perf/pmu-events/Build | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/tools/perf/pmu-events/Build b/tools/perf/pmu-events/Build
> index c5e2d5f13766..a46ab7b612df 100644
> --- a/tools/perf/pmu-events/Build
> +++ b/tools/perf/pmu-events/Build
> @@ -29,10 +29,12 @@ $(PMU_EVENTS_C): $(EMPTY_PMU_EVENTS_C)
>  	$(call rule_mkdir)
>  	$(Q)$(call echo-cmd,gen)cp $< $@
>  else
> -# Copy checked-in json for generation.
> +# Copy checked-in json to OUTPUT for generation if it's an out of source build
> +ifneq ($(OUTPUT),)
>  $(OUTPUT)pmu-events/arch/%: pmu-events/arch/%
>  	$(call rule_mkdir)
>  	$(Q)$(call echo-cmd,gen)cp $< $@
> +endif
>  
>  $(LEGACY_CACHE_JSON): $(LEGACY_CACHE_PY)
>  	$(call rule_mkdir)
> 
> -- 
> 2.34.1
>