linux-kernel - Re: [PATCH 1/2] riscv: dts: spacemit: add Ethernet and PDMA to OrangePi RV2

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <52693a5b-e564-41f1-b430-b87784e0559b@iscas.ac.cn>
Date: Tue, 21 Oct 2025 13:39:10 +0800
From: Vivian Wang <wangruikang@...as.ac.cn>
To: michael.opdenacker@...tcommit.com
Cc: devicetree@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, linux-kernel@...r.kernel.org,
 Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, Paul Walmsley <pjw@...nel.org>,
 Palmer Dabbelt <palmer@...belt.com>, Albert Ou <aou@...s.berkeley.edu>,
 Alexandre Ghiti <alex@...ti.fr>, Yixun Lan <dlan@...too.org>
Subject: Re: [PATCH 1/2] riscv: dts: spacemit: add Ethernet and PDMA to
 OrangePi RV2

On 10/20/25 17:07, Vivian Wang wrote:

> [...]
>> +	phy-handle = <&rgmii0>;
>> +	phy-mode = "rgmii-id";
>> +	pinctrl-names = "default";
>> +	pinctrl-0 = <&gmac0_cfg>;
>> +	rx-internal-delay-ps = <0>;
>> +	tx-internal-delay-ps = <0>;
> The hardware design of OPI-RV2 is not the same as BPI-F3, so the
> parameters here deserves some scruitiny. Same for eth1 below.
(Apparently my spelling deserves scrutiny as well. Oh well.)
> I would appreciate at least iperf TCP tests in both directions on both
> ethernet ports. The expected speed should be at least 940 Mbit/sec - if
> it's much lower than that something is wrong.

Okay so this is not *necessarily* a problem, but just for context...

If you look at the DTS files provided by SpacemiT [1] you'd think the
OPI-RV2 also uses RTL8211F Ethernet PHYs. It does not. The schematics
(linked on the board main page [2]) says it uses Motorcomm YT8531C.

This doesn't mean that your DTS is wrong (because we don't write the id
here when the PHY-sent one is correct), but I hope you understand that
what I'm worried is that the electrical characteristics have been
changed since they have changed the board design. This is why I think
actually taking the time to check the delay parameters would be a good idea.

And yes, it would not be surprising if the parameters for BPI-F3 also
works completely reliably for OPI-RV2. The delay tuning has quite a bit
of margin for wiggle room. 

Thanks,
Vivian "dramforever" Wang

[1]: https://github.com/spacemit-com/linux-k1x/blob/k1/arch/riscv/boot/dts/spacemit/k1-x_orangepi-rv2.dts
[2]: http://www.orangepi.org/html/hardWare/computerAndMicrocontrollers/service-and-support/Orange-Pi-RV2.html