linux-kernel - Re: [PATCH] mmc: sdhci-of-arasan: Omit a variable reassignment in sdhci_arasan

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <d1b6ab53-f45b-426d-ae2e-8c94d1cc885b@amd.com>
Date: Tue, 21 Oct 2025 08:10:54 +0200
From: Michal Simek <michal.simek@....com>
To: Markus Elfring <Markus.Elfring@....de>, linux-mmc@...r.kernel.org,
 linux-arm-kernel@...ts.infradead.org, Adrian Hunter
 <adrian.hunter@...el.com>, Andy Shevchenko <andriy.shevchenko@...el.com>,
 Muhammad Husaini Zulkifli <muhammad.husaini.zulkifli@...el.com>,
 Ulf Hansson <ulf.hansson@...aro.org>
Cc: LKML <linux-kernel@...r.kernel.org>, Anand Moon <linux.amoon@...il.com>,
 Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] mmc: sdhci-of-arasan: Omit a variable reassignment in
 sdhci_arasan_probe()



On 10/20/25 15:22, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 20 Oct 2025 15:15:07 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete a redundant variable reassignment.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>
> ---
>   drivers/mmc/host/sdhci-of-arasan.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/mmc/host/sdhci-of-arasan.c b/drivers/mmc/host/sdhci-of-arasan.c
> index c6f09b53325d..b97d042897ad 100644
> --- a/drivers/mmc/host/sdhci-of-arasan.c
> +++ b/drivers/mmc/host/sdhci-of-arasan.c
> @@ -1991,7 +1991,7 @@ static int sdhci_arasan_probe(struct platform_device *pdev)
>   
>   	ret = mmc_of_parse(host->mmc);
>   	if (ret) {
> -		ret = dev_err_probe(dev, ret, "parsing dt failed.\n");
> +		dev_err_probe(dev, ret, "parsing dt failed.\n");
>   		goto unreg_clk;
>   	}
>   

I don't really mind.

Acked-by: Michal Simek <michal.simek@....com>

Thanks,
Michal