linux-kernel - Re: [PATCH] perf build: Fix perf build issues with fixdep

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d51ff72b-3d98-4dd3-99fe-80ccdc71913d@leemhuis.info>
Date: Tue, 21 Oct 2025 08:25:16 +0200
From: Thorsten Leemhuis <linux@...mhuis.info>
To: Josh Poimboeuf <jpoimboe@...nel.org>, x86@...nel.org
Cc: linux-kernel@...r.kernel.org, Arthur Marsh
 <arthur.marsh@...ernode.on.net>, Peter Zijlstra <peterz@...radead.org>,
 Arnaldo Carvalho de Melo <acme@...nel.org>
Subject: Re: [PATCH] perf build: Fix perf build issues with fixdep



On 10/20/25 22:33, Josh Poimboeuf wrote:
> Commit a808a2b35f66 ("tools build: Fix fixdep dependencies") broke the
> perf build ("make -C tools/perf") by introducing two inadvertent
> conflicts:
> 
>   1) tools/build/Makefile includes tools/build/Makefile.include, which
>      defines a phony 'fixdep' target.  This conflicts with the $(FIXDEP)
>      file target in tools/build/Makefile when OUTPUT is empty, causing
>      make to report duplicate recipes for the same target.
> 
>   2) The FIXDEP variable in tools/build/Makefile conflicts with the
>      previously existing one in tools/perf/Makefile.perf.
> 
> Remove the unnecessary include of tools/build/Makefile.include from
> tools/build/Makefile, and rename the FIXDEP variable in
> tools/perf/Makefile.perf to FIXDEP_BUILT.
> 
> Fixes: a808a2b35f66 ("tools build: Fix fixdep dependencies")
> Reported-by: Thorsten Leemhuis <linux@...mhuis.info>

Many thx, that did the trick for me.

Closes:
https://lore.kernel.org/all/c1d395c6-2d3b-4504-befe-6e67c7ed96fc@leemhuis.info/
Tested-by: Thorsten Leemhuis <linux@...mhuis.info>

Ciao, Thorsten