linux-kernel - Re: [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <20251021074619.3638-1-guojinhui.liam@bytedance.com>
Date: Tue, 21 Oct 2025 15:46:19 +0800
From: Jinhui Guo <guojinhui.liam@...edance.com>
To: mika.westerberg@...ux.intel.com
Cc: andi.shyti@...nel.org,
	andriy.shevchenko@...ux.intel.com,
	guojinhui.liam@...edance.com,
	jsd@...ihalf.com,
	linux-i2c@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: Re: [PATCH 1/1] i2c: designware: Disable SMBus interrupts to prevent storms from mis-configured firmware

Hi,

On Mon, Oct 20, 2025 12:29:58 +0200, Mika Westerberg wrote:
> > +static inline void i2c_dw_disable_smbus_intr(struct dw_i2c_dev *dev)
> > +{
> > +	regmap_write(dev->map, DW_IC_SMBUS_INTR_MASK, 0);
> > +}

> I wonder instead of this wrapper, can you just do this in
> i2c_dw_init_master() right after the adapter has been disabled?

We can do that to simplify the code. Patch v2 is sent and has been tested.
https://lore.kernel.org/all/20251021072431.3427-1-guojinhui.liam@bytedance.com/

Thanks,
Jinhui