[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <aPc9-wYxGB1KYPyQ@phenom.ffwll.local>
Date: Tue, 21 Oct 2025 10:02:03 +0200
From: Simona Vetter <simona.vetter@...ll.ch>
To: Shengjiu Wang <shengjiu.wang@....com>
Cc: andrzej.hajda@...el.com, neil.armstrong@...aro.org, rfoss@...nel.org,
Laurent.pinchart@...asonboard.com, jonas@...boo.se,
jernej.skrabec@...il.com, maarten.lankhorst@...ux.intel.com,
mripard@...nel.org, tzimmermann@...e.de, airlied@...il.com,
simona@...ll.ch, lumag@...nel.org, dianders@...omium.org,
cristian.ciocaltea@...labora.com, luca.ceresoli@...tlin.com,
dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
victor.liu@....com, shawnguo@...nel.org, s.hauer@...gutronix.de,
kernel@...gutronix.de, festevam@...il.com, imx@...ts.linux.dev,
linux-arm-kernel@...ts.infradead.org, robh@...nel.org,
krzk+dt@...nel.org, conor+dt@...nel.org, p.zabel@...gutronix.de,
devicetree@...r.kernel.org, l.stach@...gutronix.de,
shengjiu.wang@...il.com, perex@...ex.cz, tiwai@...e.com,
linux-sound@...r.kernel.org
Subject: Re: [PATCH v7 1/7] dt-bindings: display: imx: add HDMI PAI for
i.MX8MP
On Tue, Sep 23, 2025 at 01:29:55PM +0800, Shengjiu Wang wrote:
> Add binding for the i.MX8MP HDMI parallel Audio interface block.
>
> The HDMI TX Parallel Audio Interface (HTX_PAI) is a digital module that
> acts as the bridge between the Audio Subsystem to the HDMI TX Controller.
> This IP block is found in the HDMI subsystem of the i.MX8MP SoC.
>
> Aud2htx module in Audio Subsystem, HDMI PAI module and HDMI TX
> Controller compose the HDMI audio pipeline.
>
> In fsl,imx8mp-hdmi-tx.yaml, add port@2 that is linked to pai_to_hdmi_tx.
>
> Signed-off-by: Shengjiu Wang <shengjiu.wang@....com>
> Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
> Tested-by: Alexander Stein <alexander.stein@...tq-group.com>
dt patches need an ack from dt maintainers before you push them, please
make sure you follow that for the next changes.
-Sima
> ---
> .../display/bridge/fsl,imx8mp-hdmi-tx.yaml | 12 ++++
> .../display/imx/fsl,imx8mp-hdmi-pai.yaml | 69 +++++++++++++++++++
> 2 files changed, 81 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml b/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml
> index 05442d437755..6211ab8bbb0e 100644
> --- a/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml
> +++ b/Documentation/devicetree/bindings/display/bridge/fsl,imx8mp-hdmi-tx.yaml
> @@ -49,6 +49,10 @@ properties:
> $ref: /schemas/graph.yaml#/properties/port
> description: HDMI output port
>
> + port@2:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Parallel audio input port
> +
> required:
> - port@0
> - port@1
> @@ -98,5 +102,13 @@ examples:
> remote-endpoint = <&hdmi0_con>;
> };
> };
> +
> + port@2 {
> + reg = <2>;
> +
> + endpoint {
> + remote-endpoint = <&pai_to_hdmi_tx>;
> + };
> + };
> };
> };
> diff --git a/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml
> new file mode 100644
> index 000000000000..4f99682a308d
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/imx/fsl,imx8mp-hdmi-pai.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/imx/fsl,imx8mp-hdmi-pai.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Freescale i.MX8MP HDMI Parallel Audio Interface
> +
> +maintainers:
> + - Shengjiu Wang <shengjiu.wang@....com>
> +
> +description:
> + The HDMI TX Parallel Audio Interface (HTX_PAI) is a bridge between the
> + Audio Subsystem to the HDMI TX Controller.
> +
> +properties:
> + compatible:
> + const: fsl,imx8mp-hdmi-pai
> +
> + reg:
> + maxItems: 1
> +
> + interrupts:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + clock-names:
> + const: apb
> +
> + power-domains:
> + maxItems: 1
> +
> + port:
> + $ref: /schemas/graph.yaml#/properties/port
> + description: Output to the HDMI TX controller.
> +
> +required:
> + - compatible
> + - reg
> + - interrupts
> + - clocks
> + - clock-names
> + - power-domains
> + - port
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + #include <dt-bindings/clock/imx8mp-clock.h>
> + #include <dt-bindings/power/imx8mp-power.h>
> +
> + audio-bridge@...c4800 {
> + compatible = "fsl,imx8mp-hdmi-pai";
> + reg = <0x32fc4800 0x800>;
> + interrupt-parent = <&irqsteer_hdmi>;
> + interrupts = <14>;
> + clocks = <&clk IMX8MP_CLK_HDMI_APB>;
> + clock-names = "apb";
> + power-domains = <&hdmi_blk_ctrl IMX8MP_HDMIBLK_PD_PAI>;
> +
> + port {
> + pai_to_hdmi_tx: endpoint {
> + remote-endpoint = <&hdmi_tx_from_pai>;
> + };
> + };
> + };
> --
> 2.34.1
>
--
Simona Vetter
Software Engineer
http://blog.ffwll.ch
Powered by blists - more mailing lists