linux-kernel - Re: [PATCH] exfat: fix refcount leak in exfat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPdIkNGpwXwA/SMz@chcpu18>
Date: Tue, 21 Oct 2025 08:47:12 +0000
From: Shuhao Fu <sfual@....ust.hk>
To: "Yuezhang.Mo@...y.com" <Yuezhang.Mo@...y.com>
Cc: Namjae Jeon <linkinjeon@...nel.org>, Sungjong Seo <sj1557.seo@...sung.com>,
        "linux-fsdevel@...r.kernel.org" <linux-fsdevel@...r.kernel.org>,
        "linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] exfat: fix refcount leak in exfat_find

On Tue, Oct 21, 2025 at 08:21:57AM +0000, Yuezhang.Mo@...y.com wrote:
> On Tue, Oct 21, 2025 16:04 Shuhao Fu <sfual@....ust.hk> wrote:
> > On Tue, Oct 21, 2025 at 01:38:29AM +0000, Yuezhang.Mo@...y.com wrote:
> > > On Mon, Oct 20, 2025 23:00 Shuhao Fu <sfual@....ust.hk> wrote:
> > > 
> > > I think it would be better to move these checks after exfat_put_dentry_set().
> > > Because the following check will correct ->valid_size and ->size.
> > > 
> > >         if (!is_valid_cluster(sbi, info->start_clu) && info->size) {
> > >                 exfat_warn(sb, "start_clu is invalid cluster(0x%x)",
> > >                                 info->start_clu);
> > >                 info->size = 0;
> > >                 info->valid_size = 0;
> > >         }
> > > 
> > 
> > Do you mean that we should put these two checks after
> > `exfat_put_dentry_set`, like below?
> > 
> 
> Yes, that's what I mean.
> 

Thank you for your suggestion. Patch v2 has been sent out addressing
your comments.

https://lore.kernel.org/linux-fsdevel/aPdHWFiCupwDRiFM@osx.local/