linux-kernel - Re: [PATCH v3] media: i2c: imx214: Rearrange control initialization

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPdPyc6Lasmp3EzC@kekkonen.localdomain>
Date: Tue, 21 Oct 2025 12:18:01 +0300
From: Sakari Ailus <sakari.ailus@...ux.intel.com>
To: Ricardo Ribalda <ribalda@...omium.org>
Cc: Ricardo Ribalda <ribalda@...nel.org>,
	Hans Verkuil <hverkuil+cisco@...nel.org>,
	Dan Carpenter <dan.carpenter@...aro.org>,
	linux-media@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] media: i2c: imx214: Rearrange control initialization

Hi Ricardo,

Thank you for the update.

On Mon, Oct 20, 2025 at 08:18:13PM +0000, Ricardo Ribalda wrote:
> Smatch is confused by the control initialization logic. It assumes that
> there can be a case where imx214->link_freq can be NULL and ctrls_init
> returns 0.
> 
> Re-arrage the function to make smatch happy.
> 
> This patch fixes this smatch error:
> drivers/media/i2c/imx214.c:1109 imx214_ctrls_init() error: we previously assumed 'imx214->link_freq' could be null (see line 1017)
> 
> Signed-off-by: Ricardo Ribalda <ribalda@...omium.org>

Acked-by: Sakari Ailus <sakari.ailus@...ux.intel.com>

-- 
Sakari Ailus