linux-kernel - Re: [PATCH v2] exfat: fix refcount leak in exfat

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <7d9a7fa8-4121-4239-8f5f-fb4268e148bd@web.de>
Date: Tue, 21 Oct 2025 11:20:59 +0200
From: Markus Elfring <Markus.Elfring@....de>
To: Shuhao Fu <sfual@....ust.hk>, linux-fsdevel@...r.kernel.org,
 Namjae Jeon <linkinjeon@...nel.org>, Sungjong Seo <sj1557.seo@...sung.com>
Cc: LKML <linux-kernel@...r.kernel.org>, Yuezhang Mo <yuezhang.mo@...y.com>
Subject: Re: [PATCH v2] exfat: fix refcount leak in exfat_find

…
> Function `exfat_get_dentry_set` would increase the reference counter of 
> `es->bh` on success. Therefore, `exfat_put_dentry_set` must be called
> after `exfat_get_dentry_set` to ensure refcount consistency. This patch
> relocate two checks to avoid possible leaks.
…

* Would it be preferred to refer to the term “reference count” in consistent ways?

* I see possibilities to improve such a change description another bit.
  https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git/tree/Documentation/process/submitting-patches.rst?h=v6.18-rc1#n94


Regards,
Markus