linux-kernel - Re: [PATCH] mm/damon/sysfs: Remove misleading todo comment in nid

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021010847.68473-1-sj@kernel.org>
Date: Mon, 20 Oct 2025 18:08:46 -0700
From: SeongJae Park <sj@...nel.org>
To: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
Cc: SeongJae Park <sj@...nel.org>,
	Andrew Morton <akpm@...ux-foundation.org>,
	damon@...ts.linux.dev (open list:DAMON),
	linux-mm@...ck.org (open list:DAMON),
	linux-kernel@...r.kernel.org (open list),
	skhan@...uxfoundation.org,
	david.hunter.linux@...il.com
Subject: Re: [PATCH] mm/damon/sysfs: Remove misleading todo comment in nid_show()

Hello Swaraj,

On Tue, 21 Oct 2025 02:17:13 +0000 Swaraj Gaikwad <swarajgaikwad1925@...il.com> wrote:

> The TODO comment in nid_show() suggested returning an error if the goal was
> not using nid. However, this comment was found to be inaccurate and misleading.
> This patch removes the TODO comment without changing any existing behavior.

checkpatch.pl complains as below.

    WARNING: Prefer a maximum 75 chars per line (possible unwrapped commit description?)
    #10:
    not using nid. However, this comment was found to be inaccurate and misleading.

> 
> This change follows feedback from SJ who pointed out that wiring-order

s/wiring/writing/

Also, giving a pointer to the previous discussion could be a good practice, in
my opinion.  E.g.,

   This change follows feedback from SJ who pointed out [1] that ...
   [...]
   [1] https://lore.kernel.org/20251020151315.66260-1-sj@kernel.org

> independence is expected and the function should simply show the last set value.
> 
> No functional code changes were made.
> 
> Tested with KUnit:
> - Built kernel with KUnit and DAMON sysfs tests enabled.
> - Executed KUnit tests:
>   ./kunit.py run --kunitconfig ./mm/mm/damon/tests/.kunitconfig

Not an important thing, but...  if you were doing this on the root of
unmodified linux tree, the command you executed would be,

./tools/testing/kunit/kunit.py run --kunitconfig ./mm/damon/tests

I guess it was just a simple copy-and-pasta mistake and I don't really mind,
though.

> - All 25 tests passed, including damon_sysfs_test_add_targets.
> 
> Signed-off-by: Swaraj Gaikwad <swarajgaikwad1925@...il.com>
> Suggested-by: SeongJae Park <sj@...nel.org>

Other than the abovely mentioned trivial things, so nice patch, thank you!  For
another version of this patch that the above trivial things are fixed, please
feel free to add below.

Reviewed-by: SeongJae Park <sj@...nel.org>


Thanks,
SJ

[...]