linux-kernel - Re: [PATCH net-next v02 3/6] hinic3: Add NIC configuration ops

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <465d5a38-abee-40b4-9026-aefaf47a943c@redhat.com>
Date: Tue, 21 Oct 2025 12:02:59 +0200
From: Paolo Abeni <pabeni@...hat.com>
To: Fan Gong <gongfan1@...wei.com>, Zhu Yikai <zhuyikai1@...artners.com>,
 netdev@...r.kernel.org, "David S. Miller" <davem@...emloft.net>,
 Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>,
 Simon Horman <horms@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
 Markus.Elfring@....de, pavan.chebbi@...adcom.com
Cc: linux-kernel@...r.kernel.org, linux-doc@...r.kernel.org,
 luosifu <luosifu@...wei.com>, Xin Guo <guoxin09@...wei.com>,
 Shen Chenyang <shenchenyang1@...ilicon.com>,
 Zhou Shuai <zhoushuai28@...wei.com>, Wu Like <wulike1@...wei.com>,
 Shi Jing <shijing34@...wei.com>, Luo Yang <luoyang82@...artners.com>,
 Meny Yossefi <meny.yossefi@...wei.com>, Gur Stavi <gur.stavi@...wei.com>
Subject: Re: [PATCH net-next v02 3/6] hinic3: Add NIC configuration ops

On 10/17/25 10:30 AM, Fan Gong wrote:
> @@ -368,12 +407,16 @@ static void hinic3_nic_remove(struct auxiliary_device *adev)
>  	netdev = nic_dev->netdev;
>  	unregister_netdev(netdev);
>  
> +	cancel_delayed_work_sync(&nic_dev->periodic_work);

periodic_work unconditionally reschedule itself, I think you shoudl use
disable_delayed_work_sync() here.

> +	destroy_workqueue(nic_dev->workq);
> +
>  	hinic3_update_nic_feature(nic_dev, 0);
>  	hinic3_set_nic_feature_to_hw(nic_dev);
>  	hinic3_sw_uninit(netdev);
>  
>  	hinic3_free_nic_io(nic_dev);
>  
> +	kfree(nic_dev->vlan_bitmap);
>  	free_netdev(netdev);
>  }

[...]> @@ -406,6 +418,8 @@ static void hinic3_vport_down(struct
net_device *netdev)
>  	netif_carrier_off(netdev);
>  	netif_tx_disable(netdev);
>  
> +	cancel_delayed_work_sync(&nic_dev->moderation_task);

Same here.

/P