linux-kernel - Re: [PATCH] usb: typec-mux: ptn36502: Omit a variable reassignment in ptn36502

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPdbvC6Fz4kZ9x8q@kuha.fi.intel.com>
Date: Tue, 21 Oct 2025 13:09:00 +0300
From: Heikki Krogerus <heikki.krogerus@...ux.intel.com>
To: Markus Elfring <Markus.Elfring@....de>
Cc: linux-usb@...r.kernel.org,
	Dmitry Baryshkov <dmitry.baryshkov@...aro.org>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	Neil Armstrong <neil.armstrong@...aro.org>,
	kernel-janitors@...r.kernel.org,
	LKML <linux-kernel@...r.kernel.org>,
	Anand Moon <linux.amoon@...il.com>,
	Christophe Jaillet <christophe.jaillet@...adoo.fr>
Subject: Re: [PATCH] usb: typec-mux: ptn36502: Omit a variable reassignment
 in ptn36502_probe()

On Mon, Oct 20, 2025 at 06:00:06PM +0200, Markus Elfring wrote:
> From: Markus Elfring <elfring@...rs.sourceforge.net>
> Date: Mon, 20 Oct 2025 17:50:12 +0200
> 
> An error code was assigned to a variable and checked accordingly.
> This value was passed to a dev_err_probe() call in an if branch.
> This function is documented in the way that the same value is returned.
> Thus delete a redundant variable reassignment.
> 
> The source code was transformed by using the Coccinelle software.
> 
> Signed-off-by: Markus Elfring <elfring@...rs.sourceforge.net>

Reviewed-by: Heikki Krogerus <heikki.krogerus@...ux.intel.com>

> ---
>  drivers/usb/typec/mux/ptn36502.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/typec/mux/ptn36502.c b/drivers/usb/typec/mux/ptn36502.c
> index 129d9d24b932..b1a2977b974c 100644
> --- a/drivers/usb/typec/mux/ptn36502.c
> +++ b/drivers/usb/typec/mux/ptn36502.c
> @@ -339,7 +339,7 @@ static int ptn36502_probe(struct i2c_client *client)
>  
>  	ret = regulator_enable(ptn->vdd18_supply);
>  	if (ret) {
> -		ret = dev_err_probe(dev, ret, "Failed to enable vdd18\n");
> +		dev_err_probe(dev, ret, "Failed to enable vdd18\n");
>  		goto err_mux_put;
>  	}
>  
> -- 
> 2.51.1

-- 
heikki