linux-kernel - Re: [PATCH 2/2] x86/cpu: Fix kernel-doc for 'centaur_get_free

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021103739.GBaPdic1JTakX2bA9i@fat_crate.local>
Date: Tue, 21 Oct 2025 12:37:39 +0200
From: Borislav Petkov <bp@...en8.de>
To: Kael D'Alcamo <dev@...l-k.io>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
	Dave Hansen <dave.hansen@...ux.intel.com>, x86@...nel.org,
	"H. Peter Anvin" <hpa@...or.com>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH 2/2] x86/cpu: Fix kernel-doc for 'centaur_get_free_region'

On Sun, Oct 05, 2025 at 10:41:21PM +0200, Kael D'Alcamo wrote:
> Signed-off-by: Kael D'Alcamo <dev@...l-k.io>
> ---
>  arch/x86/kernel/cpu/mtrr/centaur.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/x86/kernel/cpu/mtrr/centaur.c b/arch/x86/kernel/cpu/mtrr/centaur.c
> index 6f6c3ae92943..f4c72402c284 100644
> --- a/arch/x86/kernel/cpu/mtrr/centaur.c
> +++ b/arch/x86/kernel/cpu/mtrr/centaur.c
> @@ -20,6 +20,7 @@ static u8 centaur_mcr_type;	/* 0 for winchip, 1 for winchip2 */
>   *
>   * @base: The starting (base) address of the region.
>   * @size: The size (in bytes) of the region.
> + * @replace_reg: mtrr index to be replaced; set to invalid value if none.

I'm afraid I can't follow here what invalid value you mean...

In any case, pls merge those two into a single patch and make sure it has
a commit message.

Thx.

-- 
Regards/Gruss,
    Boris.

https://people.kernel.org/tglx/notes-about-netiquette