linux-kernel - Re: [PATCH v2] mfd: da9063: occupy second I2C address, too

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251021110847.GG475031@google.com>
Date: Tue, 21 Oct 2025 12:08:47 +0100
From: Lee Jones <lee@...nel.org>
To: Wolfram Sang <wsa+renesas@...g-engineering.com>
Cc: linux-renesas-soc@...r.kernel.org, linux-kernel@...r.kernel.org,
	Peter Rosin <peda@...ntia.se>,
	Bartosz Golaszewski <bgolaszewski@...libre.com>,
	Kieran Bingham <kieran.bingham+renesas@...asonboard.com>,
	Support Opensource <support.opensource@...semi.com>
Subject: Re: [PATCH v2] mfd: da9063: occupy second I2C address, too

On Tue, 07 Oct 2025, Wolfram Sang wrote:

> The second address can be used as a shortcut to access register pages
> 2+3. The driver does not use this feature yet. The second address should
> still be marked as used, otherwise userspace could interfere with the
> driver.

Perfect.  Thanks for updating.

> Signed-off-by: Wolfram Sang <wsa+renesas@...g-engineering.com>
> Reviewed-by: Peter Rosin <peda@...ntia.se>
> Reviewed-by: Bartosz Golaszewski <bgolaszewski@...libre.com>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@...asonboard.com>
> ---
> 
> Change since v1: reworded commit message
> 
>  drivers/mfd/da9063-i2c.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/drivers/mfd/da9063-i2c.c b/drivers/mfd/da9063-i2c.c
> index 1ec9ab56442d..12f3dd927aba 100644
> --- a/drivers/mfd/da9063-i2c.c
> +++ b/drivers/mfd/da9063-i2c.c
> @@ -469,6 +469,8 @@ static int da9063_i2c_probe(struct i2c_client *i2c)
>  		}
>  	}
>  
> +	devm_i2c_new_dummy_device(&i2c->dev, i2c->adapter, i2c->addr + 1);

I still think we need a simple comment to explain why we're obtaining
and seemingly not using the address.


-- 
Lee Jones [李琼斯]