lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <202510211959.kVCWipPy-lkp@intel.com>
Date: Tue, 21 Oct 2025 20:01:13 +0800
From: kernel test robot <lkp@...el.com>
To: Sean Anderson <sean.anderson@...ux.dev>,
	Mark Brown <broonie@...nel.org>, linux-spi@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	linux-kernel@...r.kernel.org,
	Masami Hiramatsu <mhiramat@...nel.org>,
	Mathieu Desnoyers <mathieu.desnoyers@...icios.com>,
	Steven Rostedt <rostedt@...dmis.org>,
	linux-trace-kernel@...r.kernel.org,
	Sean Anderson <sean.anderson@...ux.dev>
Subject: Re: [PATCH] spi: spi-mem: Trace exec_op

Hi Sean,

kernel test robot noticed the following build errors:

[auto build test ERROR on broonie-spi/for-next]
[also build test ERROR on linus/master v6.18-rc2 next-20251021]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sean-Anderson/spi-spi-mem-Trace-exec_op/20251021-030524
base:   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git for-next
patch link:    https://lore.kernel.org/r/20251020190333.1431664-1-sean.anderson%40linux.dev
patch subject: [PATCH] spi: spi-mem: Trace exec_op
config: x86_64-buildonly-randconfig-003-20251021 (https://download.01.org/0day-ci/archive/20251021/202510211959.kVCWipPy-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251021/202510211959.kVCWipPy-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510211959.kVCWipPy-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:468:
>> include/trace/events/spi-mem.h:42:22: error: too many arguments provided to function-like macro invocation
      42 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:468:
>> include/trace/events/spi-mem.h:42:3: error: use of undeclared identifier '__assign_str'
      42 |                 __assign_str(name, mem->name);
         |                 ^
   include/trace/events/spi-mem.h:89:22: error: too many arguments provided to function-like macro invocation
      89 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:468:
   include/trace/events/spi-mem.h:89:3: error: use of undeclared identifier '__assign_str'
      89 |                 __assign_str(name, mem->name);
         |                 ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:523:
>> include/trace/events/spi-mem.h:42:22: error: too many arguments provided to function-like macro invocation
      42 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:132:
   In file included from include/trace/trace_events.h:523:
   include/trace/events/spi-mem.h:89:22: error: too many arguments provided to function-like macro invocation
      89 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:133:
   In file included from include/trace/perf.h:110:
>> include/trace/events/spi-mem.h:42:22: error: too many arguments provided to function-like macro invocation
      42 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:133:
   In file included from include/trace/perf.h:110:
>> include/trace/events/spi-mem.h:42:3: error: use of undeclared identifier '__assign_str'
      42 |                 __assign_str(name, mem->name);
         |                 ^
   include/trace/events/spi-mem.h:89:22: error: too many arguments provided to function-like macro invocation
      89 |                 __assign_str(name, mem->name);
         |                                    ^
   include/trace/stages/stage6_event_callback.h:34:9: note: macro '__assign_str' defined here
      34 | #define __assign_str(dst)                                               \
         |         ^
   In file included from drivers/spi/spi-mem.c:16:
   In file included from include/trace/events/spi-mem.h:106:
   In file included from include/trace/define_trace.h:133:
   In file included from include/trace/perf.h:110:
   include/trace/events/spi-mem.h:89:3: error: use of undeclared identifier '__assign_str'
      89 |                 __assign_str(name, mem->name);
         |                 ^
   10 errors generated.


vim +42 include/trace/events/spi-mem.h

    13	
    14	#define decode_dtr(dtr) \
    15		__print_symbolic(dtr, \
    16			{ 0, "S" }, \
    17			{ 1, "D" })
    18	
    19	TRACE_EVENT(spi_mem_start_op,
    20		TP_PROTO(struct spi_mem *mem, const struct spi_mem_op *op),
    21		TP_ARGS(mem, op),
    22	
    23		TP_STRUCT__entry(
    24			__string(name, mem->name)
    25			__dynamic_array(u8, op, 1 + op->addr.nbytes + op->dummy.nbytes)
    26			__dynamic_array(u8, data, op->data.dir == SPI_MEM_DATA_OUT ?
    27						  min(op->data.nbytes, 64) : 0)
    28			__field(u32, data_len)
    29			__field(u32, max_freq)
    30			__field(u8, cmd_buswidth)
    31			__field(bool, cmd_dtr)
    32			__field(u8, addr_buswidth)
    33			__field(bool, addr_dtr)
    34			__field(u8, dummy_nbytes)
    35			__field(u8, data_buswidth)
    36			__field(bool, data_dtr)
    37		),
    38	
    39		TP_fast_assign(
    40			int i;
    41	
  > 42			__assign_str(name, mem->name);
    43			__entry->max_freq = op->max_freq ?: mem->spi->max_speed_hz;
    44	
    45			__entry->cmd_buswidth = op->cmd.buswidth;
    46			__entry->cmd_dtr = op->cmd.dtr;
    47			*((u8 *)__get_dynamic_array(op)) = op->cmd.opcode;
    48	
    49			__entry->addr_buswidth = op->addr.buswidth;
    50			__entry->addr_dtr = op->addr.dtr;
    51			for (i = 0; i < op->addr.nbytes; i++)
    52				((u8 *)__get_dynamic_array(op))[i + 1] =
    53					op->addr.val >> (8 * (op->addr.nbytes - i - 1));
    54	
    55			memset(((u8 *)__get_dynamic_array(op)) + op->addr.nbytes + 1,
    56			       0xff, op->dummy.nbytes);
    57	
    58			__entry->data_len = op->data.nbytes;
    59			__entry->data_buswidth = op->data.buswidth;
    60			__entry->data_dtr = op->data.dtr;
    61			if (op->data.dir == SPI_MEM_DATA_OUT)
    62				memcpy(__get_dynamic_array(data), op->data.buf.out,
    63				       __get_dynamic_array_len(data));
    64		),
    65	
    66		TP_printk("%s %u%s-%u%s-%u%s @%u Hz op=[%*phD] len=%u tx=[%*phD]",
    67			__get_str(name),
    68			__entry->cmd_buswidth, decode_dtr(__entry->cmd_dtr),
    69			__entry->addr_buswidth, decode_dtr(__entry->addr_dtr),
    70			__entry->data_buswidth, decode_dtr(__entry->data_dtr),
    71			__entry->max_freq,
    72			__get_dynamic_array_len(op), __get_dynamic_array(op),
    73			__entry->data_len,
    74			__get_dynamic_array_len(data), __get_dynamic_array(data))
    75	);
    76	
    77	TRACE_EVENT(spi_mem_stop_op,
    78		TP_PROTO(struct spi_mem *mem, const struct spi_mem_op *op),
    79		TP_ARGS(mem, op),
    80	
    81		TP_STRUCT__entry(
    82			__string(name, mem->name)
    83			__dynamic_array(u8, data, op->data.dir == SPI_MEM_DATA_IN ?
    84						  min(op->data.nbytes, 64) : 0)
    85			__field(u32, data_len)
    86		),
    87	
    88		TP_fast_assign(
    89			__assign_str(name, mem->name);
    90			__entry->data_len = op->data.nbytes;
    91			if (op->data.dir == SPI_MEM_DATA_IN)
    92				memcpy(__get_dynamic_array(data), op->data.buf.in,
    93				       __get_dynamic_array_len(data));
    94		),
    95	
    96		TP_printk("%s len=%u rx=[%*phD]",
    97			__get_str(name),
    98			__entry->data_len,
    99			__get_dynamic_array_len(data), __get_dynamic_array(data))
   100	);
   101	
   102	
   103	#endif /* _TRACE_SPI_MEM_H */
   104	
   105	/* This part must be outside protection */
 > 106	#include <trace/define_trace.h>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ