linux-kernel - Re: [PATCH] qcom: ice: Prevent client probe failures on unsupported ICE

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <413d84ad-0858-4e96-94e5-c0a2ed68e6a2@quicinc.com>
Date: Tue, 21 Oct 2025 18:04:56 +0530
From: Debraj Mukhopadhyay <quic_dmukhopa@...cinc.com>
To: Konrad Dybcio <konrad.dybcio@....qualcomm.com>,
        <quic_neersoni@...cinc.com>, <andersson@...nel.org>,
        <konradybcio@...nel.org>, <linux-arm-msm@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] qcom: ice: Prevent client probe failures on unsupported
 ICE

Hi Konrad,

Thanks for your comment. Please find my response inline below.


On 10/21/2025 2:57 PM, Konrad Dybcio wrote:
> On 10/21/25 6:03 AM, Debraj Mukhopadhyay wrote:
>> Storage clients (ex. UFS and MMC) invoke of_qcom_ice_get() to obtain the
>> handle from ICE (Inline Crypto Engine) driver. Currently if ICE is
>> unsupported, the return code from probe could prevent the client
>> initialization which is a bug. To fix this a new flag
>> qcom_ice_create_error is introduced which caches the error encountered
>> during ICE probe.
> Probe currently only happens if the ICE node is present in the DT and
> referred to from the storage controller. What does this patch solve?
>
> Konrad

Even if the DT node is present it is possible that The SCM support for 
ICE is unavailable in the underlying TZ framework. With the existing 
logic, qcom_scm_ice_available() would have failed in such cases, 
returning NULL to storage clients where the clients like storage may 
keep retrying which potentially can cause boot up issues. This patch 
corrects that behavior by explicitly returning -EOPNOTSUPP to the 
clients. I will update the commit message accordingly.

Thanks,

Debraj

>
>> The qcom_ice_create() and of_qcom_ice_get() functions are updated to
>> return -EOPNOTSUPP when ICE is unsupported, allowing clients to proceed
>> without ICE.
>>
>> For other failures, such as ICE not yet initialized, the existing
>> behavior (e.g., -EPROBE_DEFER) is retained to ensure proper error
>> handling.
>>
>> This improves error signaling and ensures that client initialization is
>> not blocked unnecessarily.
>>
>> Signed-off-by: Debraj Mukhopadhyay <quic_dmukhopa@...cinc.com>
>> ---