linux-kernel - Re: [PATCH v6 00/10] PM: EM: Add netlink support for the energy model

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <58c06505-7227-4985-b3d0-e12022ef9876@arm.com>
Date: Wed, 22 Oct 2025 14:02:49 +0100
From: Lukasz Luba <lukasz.luba@....com>
To: Changwoo Min <changwoo@...lia.com>
Cc: christian.loehle@....com, tj@...nel.org, pavel@...nel.org,
 len.brown@...el.com, rafael@...nel.org, kernel-dev@...lia.com,
 linux-pm@...r.kernel.org, sched-ext@...ts.linux.dev,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v6 00/10] PM: EM: Add netlink support for the energy model

Hi Changwoo,

On 10/20/25 23:09, Changwoo Min wrote:
> Addressed all the comments from Lukasz and rebased the code to the head
> of the linus tree.
> 
> There is a need to access the energy model from the userspace. One such
> example is the sched_ext schedulers [1]. The userspace part of the
> sched_ext schedules could feed the (post-processed) energy-model
> information to the BPF part of the scheduler.
> 

[snip]

> 
> ChangeLog v5 -> v6:
>    - Fix two problems reported by the kernel test robot.
>    - Conditionally include the iterator/accessor code for the performance
>      domain when both CONFIG_ENERGY_MODEL and CONFIG_NET are set to avoid
>      the compilation errors (patch 5).
>    - Remove an unused variable, `ret`, in em_notify_pd_deleted() to avoid
>      a warning (patch 8).
> 

[snip]

> 
> Changwoo Min (10):
>    PM: EM: Assign a unique ID when creating a performance domain
>    PM: EM: Expose the ID of a performance domain via debugfs
>    PM: EM: Add em.yaml and autogen files
>    PM: EM: Add a skeleton code for netlink notification
>    PM: EM: Add an iterator and accessor for the performance domain
>    PM: EM: Implement em_nl_get_pds_doit()
>    PM: EM: Implement em_nl_get_pd_table_doit()
>    PM: EM: Implement em_notify_pd_deleted()
>    PM: EM: Implement em_notify_pd_created/updated()
>    PM: EM: Notify an event when the performance domain changes
> 
>   Documentation/netlink/specs/em.yaml | 113 ++++++++++
>   MAINTAINERS                         |   3 +
>   include/linux/energy_model.h        |   4 +
>   include/uapi/linux/energy_model.h   |  62 ++++++
>   kernel/power/Makefile               |   5 +-
>   kernel/power/em_netlink.c           | 309 ++++++++++++++++++++++++++++
>   kernel/power/em_netlink.h           |  39 ++++
>   kernel/power/em_netlink_autogen.c   |  48 +++++
>   kernel/power/em_netlink_autogen.h   |  23 +++
>   kernel/power/energy_model.c         |  85 +++++++-
>   10 files changed, 689 insertions(+), 2 deletions(-)
>   create mode 100644 Documentation/netlink/specs/em.yaml
>   create mode 100644 include/uapi/linux/energy_model.h
>   create mode 100644 kernel/power/em_netlink.c
>   create mode 100644 kernel/power/em_netlink.h
>   create mode 100644 kernel/power/em_netlink_autogen.c
>   create mode 100644 kernel/power/em_netlink_autogen.h
> 

You could still keep my review tags for this v6. The minor
issues reported by the testing robots and your fixes
didn't impact that.
(BTW, I suspected there might be those tricky build configurations
where something might pop up)

So fill free to add in all patches (like it was in v5):

Reviewed-by: Lukasz Luba <lukasz.luba@....com>

Regards,
Lukasz