linux-kernel - Re: [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add spi bus properties

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <882aa222-fe4f-4724-87eb-4480de91919d@kernel.org>
Date: Wed, 22 Oct 2025 15:42:58 +0200
From: Krzysztof Kozlowski <krzk@...nel.org>
To: Vitaly Rodionov <vitalyr@...nsource.cirrus.com>,
 Mark Brown <broonie@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>
Cc: Takashi Iwai <tiwai@...e.com>, Jaroslav Kysela <perex@...ex.cz>,
 David Rhodes <david.rhodes@...rus.com>,
 Richard Fitzgerald <rf@...nsource.cirrus.com>,
 Liam Girdwood <lgirdwood@...il.com>, Rob Herring <robh@...nel.org>,
 Conor Dooley <conor+dt@...nel.org>, linux-sound@...r.kernel.org,
 linux-kernel@...r.kernel.org, patches@...nsource.cirrus.com,
 devicetree@...r.kernel.org
Subject: Re: [PATCH v5 11/12] ASoC: dt-bindings: sound: cirrus: cs530x: add
 spi bus properties

On 22/10/2025 15:38, Vitaly Rodionov wrote:
> This patch adds property for cs530x SPI control bus
> with max frequency 24MHz.

Why?

You described what you did, we see that from the diff. Explain why you
are doing this, e.g. hardware is like that? Old hardware? New hardware?
Both? If only new, then why this is a separate patch?

Also, since I expect new version:
Please do not use "This commit/patch/change", but imperative mood. See
longer explanation here:
https://elixir.bootlin.com/linux/v6.16/source/Documentation/process/submitting-patches.rst#L94

Best regards,
Krzysztof