linux-kernel - Re: [RFC PATCH v2] page_alloc: allow migration of smaller hugepages during contig

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <aPjv-Kd2ZihLUqMS@gourry-fedora-PF4VCD3F>
Date: Wed, 22 Oct 2025 10:53:44 -0400
From: Gregory Price <gourry@...rry.net>
To: SeongJae Park <sj@...nel.org>
Cc: linux-mm@...ck.org, linux-kernel@...r.kernel.org, kernel-team@...a.com,
	akpm@...ux-foundation.org, vbabka@...e.cz, surenb@...gle.com,
	mhocko@...e.com, jackmanb@...gle.com, hannes@...xchg.org,
	ziy@...dia.com, David Hildenbrand <david@...hat.com>
Subject: Re: [RFC PATCH v2] page_alloc: allow migration of smaller hugepages
 during contig_alloc.

On Tue, Oct 21, 2025 at 06:40:57PM -0700, SeongJae Park wrote:
> On Mon, 20 Oct 2025 17:08:16 -0400 Gregory Price <gourry@...rry.net> wrote:
> > +
> > +			/* Don't consider moving same size/larger pages */
> > +			page = compound_head(page);
> > +			order = compound_order(page);
> > +			if ((order >= MAX_PAGE_ORDER) ||
> > +			    (nr_pages < (1 << order)))
> > +				return false;
> 
> Shouldn't the comparison of 'nr_pages' against '1 << order' use '<=' instead of
> '<', to match the commit description?
> 

Good catch, got lost in the shuffle.  Thank you!

~Gregory