linux-kernel - Re: [PATCH] io_uring: initialize vairable "sqe" to silence build warning

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <2025102217-manicure-debtor-4d0f@gregkh>
Date: Wed, 22 Oct 2025 17:17:56 +0200
From: Greg KH <gregkh@...uxfoundation.org>
To: Mallikarjun Thammanavar <mallikarjunst09@...il.com>
Cc: axboe@...nel.dk, io-uring@...r.kernel.org, linux-kernel@...r.kernel.org,
	regressions@...ts.linux.dev,
	"kernelci . org bot" <bot@...nelci.org>
Subject: Re: [PATCH] io_uring: initialize vairable "sqe" to silence build
 warning

On Wed, Oct 22, 2025 at 05:07:16PM +0200, Mallikarjun Thammanavar wrote:
> clang-17 compiler throws build error when [-Werror,-Wuninitialized] are enabled
> error: variable 'sqe' is uninitialized when used here [-Werror,-Wuninitialized]
> 
> Initialize struct io_uring_sqe *sqe = NULL; to have clean build
> Reported-by: kernelci.org bot <bot@...nelci.org>
> Link: https://lore.kernel.org/regressions/176110914348.5309.724397608932251368@15dd6324cc71/
> 
> Signed-off-by: Mallikarjun Thammanavar <mallikarjunst09@...il.com>
> ---
>  io_uring/fdinfo.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/io_uring/fdinfo.c b/io_uring/fdinfo.c
> index d5aa64203de5..e5792b794f8b 100644
> --- a/io_uring/fdinfo.c
> +++ b/io_uring/fdinfo.c
> @@ -89,7 +89,7 @@ static void __io_uring_show_fdinfo(struct io_ring_ctx *ctx, struct seq_file *m)
>  	seq_printf(m, "CachedCqTail:\t%u\n", data_race(ctx->cached_cq_tail));
>  	seq_printf(m, "SQEs:\t%u\n", sq_tail - sq_head);
>  	while (sq_head < sq_tail) {
> -		struct io_uring_sqe *sqe;
> +		struct io_uring_sqe *sqe = NULL;

If you do that, then other tools will report a NULL dereference, right?

Please fix the tools, don't paper over stuff like this.

thanks,

greg k-h