linux-kernel - Re: linux-next: build failure after merge of the tip tree

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <aPhGo5WjbPM1Yu95@tardis-2.local>
Date: Tue, 21 Oct 2025 22:51:15 -0400
From: Boqun Feng <boqun.feng@...il.com>
To: Stephen Rothwell <sfr@...b.auug.org.au>
Cc: Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...nel.org>,
	"H. Peter Anvin" <hpa@...or.com>,
	Peter Zijlstra <peterz@...radead.org>,
	Daniel Almeida <daniel.almeida@...labora.com>,
	Linux Kernel Mailing List <linux-kernel@...r.kernel.org>,
	Linux Next Mailing List <linux-next@...r.kernel.org>,
	Matthew Maurer <mmaurer@...gle.com>,
	Danilo Krummrich <dakr@...nel.org>
Subject: Re: linux-next: build failure after merge of the tip tree

On Tue, Oct 21, 2025 at 10:18:58PM -0400, Boqun Feng wrote:
> On Wed, Oct 22, 2025 at 11:46:44AM +1100, Stephen Rothwell wrote:
> > Hi all,
> > 
> 
> Hi Stephen,
> 
> Thanks for reporting this.
> 
> Cc Mathhew and Danilo,
> 

(now really Cc them...)

Regards,
Boqun

> > After merging the tip tree, today's linux-next build (x86_64 allmodconfig)
> > failed like this:
> > 
> > error[E0594]: cannot assign to data in dereference of `lock::Guard<'_, T, MutexBackend>`
> >   --> rust/kernel/debugfs/traits.rs:64:9
> >    |
> > 64 |         *self.lock() = val;
> >    |         ^^^^^^^^^^^^ cannot assign
> >    |
> >    = help: trait `DerefMut` is required to modify through a dereference, but it is not implemented for `lock::Guard<'_, T, MutexBackend>`
> > 
> 
> Could we make the `impl Reader` for `Mutex<T>` to bound where `T:
> Unpin`? Since `Mutex<T>` is structurally pinning `T`, you cannot use
> `*self.lock()` to overwrite `T` directly. And that'll fix this.
> 
> Thanks!
> 
> Regards,
> Boqun
> 
> > error: aborting due to 1 previous error
> > 
> > For more information about this error, try `rustc --explain E0594`.
> > 
> > Caused by commit
> > 
> >   da123f0ee40f ("rust: lock: guard: Add T: Unpin bound to DerefMut")
> > 
> > I have used the tip tree from next-20251021 for today.
> > 
> > -- 
> > Cheers,
> > Stephen Rothwell
> 
>