linux-kernel - Re: [PATCH 3/3] gpu: nova-core: bitfield: remove BitOr implementation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ecc69b04-3746-4119-b1ab-fc666d6ca352@nvidia.com>
Date: Wed, 22 Oct 2025 12:11:01 -0400
From: Joel Fernandes <joelagnelf@...dia.com>
To: Alexandre Courbot <acourbot@...dia.com>,
 Danilo Krummrich <dakr@...nel.org>, Alice Ryhl <aliceryhl@...gle.com>,
 Edwin Peer <epeer@...dia.com>
Cc: John Hubbard <jhubbard@...dia.com>, Alistair Popple <apopple@...dia.com>,
 Timur Tabi <ttabi@...dia.com>, nouveau@...ts.freedesktop.org,
 dri-devel@...ts.freedesktop.org, linux-kernel@...r.kernel.org,
 rust-for-linux@...r.kernel.org
Subject: Re: [PATCH 3/3] gpu: nova-core: bitfield: remove BitOr implementation



On 10/22/2025 6:50 AM, Alexandre Courbot wrote:
> Using this operand can produce invalid values. It also doesn't bring
> any benefit as one can use the builder pattern to assemble a new value.>> Reported-by: Edwin Peer <epeer@...dia.com>
> Link: https://lore.kernel.org/rust-for-linux/F3853912-2C1C-4F9B-89B0-3168689F35B3@nvidia.com/
> Signed-off-by: Alexandre Courbot <acourbot@...dia.com>
Yeah, we should get rid of BitOr.

Reviewed-by: Joel Fernandes <joelagnelf@...dia.com>

Thanks.