linux-kernel - Re: [PATCH v3 3/5] dt-bindings: pinctrl: document polarfire soc iomux0 pinmux

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20251022-segment-subfloor-9594ee438da8@spud>
Date: Wed, 22 Oct 2025 18:12:41 +0100
From: Conor Dooley <conor@...nel.org>
To: linus.walleij@...aro.org
Cc: Conor Dooley <conor.dooley@...rochip.com>,
	Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	linux-kernel@...r.kernel.org, linux-gpio@...r.kernel.org,
	devicetree@...r.kernel.org, Valentina.FernandezAlanis@...rochip.com
Subject: Re: [PATCH v3 3/5] dt-bindings: pinctrl: document polarfire soc
 iomux0 pinmux

On Wed, Oct 22, 2025 at 11:09:11AM +0100, Conor Dooley wrote:
> From: Conor Dooley <conor.dooley@...rochip.com>
> 
> On Polarfire SoC, iomux0 is responsible for routing functions to either
> Multiprocessor Subsystem (MSS) IOs or to the FPGA fabric, where they
> can either interface with custom RTL or be routed to the FPGA fabric's
> IOs. Document it.
> 
> Reviewed-by: Rob Herring (Arm) <robh@...nel.org>
> Signed-off-by: Conor Dooley <conor.dooley@...rochip.com>

> +patternProperties:
> +  '^mux-':
> +    type: object
> +    additionalProperties: false
> +
> +    properties:
> +      function:
> +        description:
> +          A string containing the name of the function to mux to the group.
> +        enum: [ spi0, spi1, i2c0, i2c1, can0, can1, qspi, uart0, uart1, uart2,
> +                uart3, uart4, mdio0, mdio1 ]
> +
> +      groups:
> +        description:
> +          An array of strings. Each string contains the name of a group.
> +        items:
> +          enum: [ spi0_fabric, spi0_mssio, spi1_fabric, spi1_mssio, i2c0_fabric,
> +                  i2c0_mssio, i2c1_fabric, i2c1_mssio, can0_fabric, can0_mssio,
> +                  can1_fabric, can1_mssio, qspi_fabric, qspi_mssio,
> +                  uart0_fabric, uart0_mssio, uart1_fabric, uart1_mssio,
> +                  uart2_fabric, uart2_mssio, uart3_fabric, uart3_mssio,
> +                  uart4_fabric, uart4_mssio, mdio0_fabric, mdio0_mssio,
> +                  mdio1_fabric, mdio1_mssio ]
> +
> +    required:
> +      - function
> +      - groups

I realised a few minutes ago that, despite Rob's review, there's a
mistake here. This, and the gpio2 binding, are both missing a
pinmux-node reference in these child nodes, since that's where the
types for function/groups come from.
I guess I'll send another version tomorrow Linus.

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)