linux-kernel - Re: [PATCH 1/2] dt-bindings: iio: position: Add ams AS5600 Position Sensor

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20251022-savanna-gluten-0c5397bd4de4@spud>
Date: Wed, 22 Oct 2025 18:50:49 +0100
From: Conor Dooley <conor@...nel.org>
To: Aditya Dutt <duttaditya18@...il.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	David Lechner <dlechner@...libre.com>,
	Nuno Sá <nuno.sa@...log.com>,
	Andy Shevchenko <andy@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Jonathan Corbet <corbet@....net>, Frank Zago <frank@...o.net>,
	linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org,
	devicetree@...r.kernel.org, linux-doc@...r.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: iio: position: Add ams AS5600 Position
 Sensor

On Tue, Oct 21, 2025 at 01:46:52AM +0530, Aditya Dutt wrote:
> The AS5600 is a Hall-based rotary magnetic position sensor using
> planar sensors that convert the magnetic field component perpendicular
> to the surface of the chip into a voltage, or a numerical value
> available through i2c.
> 
> Add dt-bindings for the sensor.
> 
> Datasheet: https://ams-osram.com/products/sensor-solutions/position-sensors/ams-as5600-position-sensor

Looks like this device has two supplies, could you document those
please?

Additionally, this "PGO" pin - is it necessary for a driver to know what
state it is in to function correctly? If so, can the information about
which state it is in be gathered from i2c?
Should there also be an optional pgo-gpios property for the scenario
where it is not tied, but set by a GPIO, if that is even possible.

> Signed-off-by: Aditya Dutt <duttaditya18@...il.com>
> ---
>  .../bindings/iio/position/ams,as5600.yaml     | 42 +++++++++++++++++++
>  1 file changed, 42 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/iio/position/ams,as5600.yaml
> 
> diff --git a/Documentation/devicetree/bindings/iio/position/ams,as5600.yaml b/Documentation/devicetree/bindings/iio/position/ams,as5600.yaml
> new file mode 100644
> index 000000000000..d4c92dd41dd6
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/iio/position/ams,as5600.yaml
> @@ -0,0 +1,42 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/iio/position/ams,as5600.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: ams AS5600 Position Sensor
> +
> +maintainers:
> +  - Aditya Dutt <duttaditya18@...il.com>
> +
> +description: |
> +  12-Bit Programmable Contactless Potentiometer
> +
> +properties:
> +  compatible:
> +    enum:
> +      - ams,as5600

blank line here please.

> +  reg:
> +    maxItems: 1
> +    description: |
> +      The I2C register address of the device. Typical address for AS5600: 0x36.
> +
> +required:
> +  - compatible
> +  - reg
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c {
> +      #address-cells = <1>;
> +      #size-cells = <0>;
> +
> +      ams5600@36 {

potentiometer@36

pw-bot: changes-requested

Cheers,
Conor.

> +        compatible = "ams,as5600";
> +        reg = <0x36>;
> +      };
> +    };
> +
> +...
> -- 
> 2.34.1
> 

Download attachment "signature.asc" of type "application/pgp-signature" (229 bytes)