linux-kernel - Re: [PATCH] taint/module: Remove unnecessary taint

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <caf949d7-09b4-4a36-bf38-43af13e8e308@infradead.org>
Date: Wed, 22 Oct 2025 12:31:51 -0700
From: Randy Dunlap <rdunlap@...radead.org>
To: Petr Pavlu <petr.pavlu@...e.com>,
 Andrew Morton <akpm@...ux-foundation.org>
Cc: Luis Chamberlain <mcgrof@...nel.org>, Daniel Gomez <da.gomez@...nel.org>,
 Sami Tolvanen <samitolvanen@...gle.com>, Aaron Tomlin <atomlin@...mlin.com>,
 Petr Mladek <pmladek@...e.com>, linux-modules@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH] taint/module: Remove unnecessary taint_flag.module field



On 10/22/25 1:28 AM, Petr Pavlu wrote:
> The TAINT_RANDSTRUCT and TAINT_FWCTL flags are mistakenly set in the
> taint_flags table as per-module flags. While this can be trivially

Ah, I had just noticed these this morning.

> corrected, the issue can be avoided altogether by removing the
> taint_flag.module field.
> 
> This is possible because, since commit 7fd8329ba502 ("taint/module: Clean
> up global and module taint flags handling") in 2016, the handling of module
> taint flags has been fully generic. Specifically, module_flags_taint() can
> print all flags, and the required output buffer size is properly defined in
> terms of TAINT_FLAGS_COUNT. The actual per-module flags are always those
> added to module.taints by calls to add_taint_module().
> 
> Signed-off-by: Petr Pavlu <petr.pavlu@...e.com>

Reviewed-by: Randy Dunlap <rdunlap@...radead.org>

> ---
> The patch is based on linux-next (20251021) because I wanted to avoid
> a conflict with "taint: add reminder about updating docs and scripts" [1],
> which is currently queued in mm-nonmm-unstable.
> 
> [1] https://lore.kernel.org/all/20251015221626.1126156-1-rdunlap@infradead.org/
> 
> ---
>  include/linux/panic.h |  1 -
>  kernel/module/main.c  |  2 +-
>  kernel/panic.c        | 46 ++++++++++++++++++++-----------------------
>  3 files changed, 22 insertions(+), 27 deletions(-)
> 

-- 
~Randy