linux-kernel - Re: [PATCH net] virtio-net: zero unused hash fields

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CACGkMEtUjP2UN4s2ZRF8UGV6Bb3-6oPkU50oJ0ek8qfYwxjv1w@mail.gmail.com>
Date: Wed, 22 Oct 2025 11:41:50 +0800
From: Jason Wang <jasowang@...hat.com>
To: "Michael S. Tsirkin" <mst@...hat.com>
Cc: xuanzhuo@...ux.alibaba.com, eperezma@...hat.com, pabeni@...hat.com, 
	virtualization@...ts.linux.dev, linux-kernel@...r.kernel.org, 
	netdev@...r.kernel.org, stable@...r.kernel.org
Subject: Re: [PATCH net] virtio-net: zero unused hash fields

On Tue, Oct 21, 2025 at 4:28 PM Michael S. Tsirkin <mst@...hat.com> wrote:
>
> On Tue, Oct 21, 2025 at 12:01:55PM +0800, Jason Wang wrote:
> > When GSO tunnel is negotiated virtio_net_hdr_tnl_from_skb() tries to
> > initialize the tunnel metadata but forget to zero unused rxhash
> > fields. This may leak information to another side. Fixing this by
> > zeroing the unused hash fields.
> >
> > Fixes: a2fb4bc4e2a6a ("net: implement virtio helpers to handle UDP GSO tunneling")x

I just spotted this has an unnecessary trailing 'x'. Will post V2.

> > Cc: <stable@...r.kernel.org>
> > Signed-off-by: Jason Wang <jasowang@...hat.com>
>
> Acked-by: Michael S. Tsirkin <mst@...hat.com>

Thanks