lists.openwall.net   lists  /  announce  owl-users  owl-dev  john-users  john-dev  passwdqc-users  yescrypt  popa3d-users  /  oss-security  kernel-hardening  musl  sabotage  tlsify  passwords  /  crypt-dev  xvendor  /  Bugtraq  Full-Disclosure  linux-kernel  linux-netdev  linux-ext4  linux-hardening  linux-cve-announce  PHC 
Open Source and information security mailing list archives
 
Hash Suite: Windows password security audit tool. GUI, reports in PDF.
[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <202510230450.v2a33A8Z-lkp@intel.com>
Date: Thu, 23 Oct 2025 04:24:01 +0800
From: kernel test robot <lkp@...el.com>
To: Biancaa Ramesh <biancaa2210329@....edu.in>, linux-media@...r.kernel.org
Cc: llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev,
	awalls@...metrocast.net, mchehab@...nel.org,
	linux-kernel@...r.kernel.org,
	Biancaa Ramesh <biancaa2210329@....edu.in>
Subject: Re: [PATCH] pcmcia/parport_cs: Refactor probe function and improve
 error logging

Hi Biancaa,

kernel test robot noticed the following build errors:

[auto build test ERROR on sailus-media-tree/master]
[also build test ERROR on linus/master sailus-media-tree/streams v6.18-rc2 next-20251022]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Biancaa-Ramesh/pcmcia-parport_cs-Refactor-probe-function-and-improve-error-logging/20251022-030324
base:   git://linuxtv.org/sailus/media_tree.git master
patch link:    https://lore.kernel.org/r/20251021190021.173748-1-biancaa2210329%40ssn.edu.in
patch subject: [PATCH] pcmcia/parport_cs: Refactor probe function and improve error logging
config: x86_64-buildonly-randconfig-001-20251022 (https://download.01.org/0day-ci/archive/20251023/202510230450.v2a33A8Z-lkp@intel.com/config)
compiler: clang version 20.1.8 (https://github.com/llvm/llvm-project 87f0227cb60147a26a1eeb4fb06e3b505e9c7261)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20251023/202510230450.v2a33A8Z-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@...el.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202510230450.v2a33A8Z-lkp@intel.com/

All errors (new ones prefixed by >>):

   drivers/parport/parport_cs.c:137:21: warning: unused variable 'info' [-Wunused-variable]
     137 |     parport_info_t *info = link->priv;
         |                     ^~~~
>> drivers/parport/parport_cs.c:148:11: error: use of undeclared label 'failed'
     148 |             goto failed;
         |                  ^
>> drivers/parport/parport_cs.c:169:5: error: unknown type name 'p'
     169 |     p->modes |= PARPORT_MODE_PCSPP;
         |     ^
>> drivers/parport/parport_cs.c:169:6: error: expected identifier or '('
     169 |     p->modes |= PARPORT_MODE_PCSPP;
         |      ^
   drivers/parport/parport_cs.c:170:5: error: expected identifier or '('
     170 |     if (epp_mode)
         |     ^
>> drivers/parport/parport_cs.c:172:5: error: unknown type name 'info'
     172 |     info->ndev = 1;
         |     ^
   drivers/parport/parport_cs.c:172:9: error: expected identifier or '('
     172 |     info->ndev = 1;
         |         ^
   drivers/parport/parport_cs.c:173:5: error: unknown type name 'info'
     173 |     info->port = p;
         |     ^
   drivers/parport/parport_cs.c:173:9: error: expected identifier or '('
     173 |     info->port = p;
         |         ^
   drivers/parport/parport_cs.c:175:5: error: expected identifier or '('
     175 |     return 0;
         |     ^
>> drivers/parport/parport_cs.c:177:1: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     177 | failed:
         | ^
         | int
>> drivers/parport/parport_cs.c:177:7: error: expected ';' after top level declarator
     177 | failed:
         |       ^
         |       ;
   drivers/parport/parport_cs.c:178:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     178 |         parport_cs_release(link);
         |         ^
         |         int
>> drivers/parport/parport_cs.c:178:21: error: a parameter list without types is only allowed in a function definition
     178 |         parport_cs_release(link);
         |                            ^
>> drivers/parport/parport_cs.c:179:8: error: unknown type name 'link'
     179 |         kfree(link->priv);
         |               ^
>> drivers/parport/parport_cs.c:179:12: error: expected ')'
     179 |         kfree(link->priv);
         |                   ^
   drivers/parport/parport_cs.c:179:7: note: to match this '('
     179 |         kfree(link->priv);
         |              ^
   drivers/parport/parport_cs.c:179:2: error: type specifier missing, defaults to 'int'; ISO C99 and later do not support implicit int [-Wimplicit-int]
     179 |         kfree(link->priv);
         |         ^
         |         int
   drivers/parport/parport_cs.c:180:5: error: unknown type name 'link'
     180 |     link->priv = NULL;
         |     ^
   drivers/parport/parport_cs.c:180:9: error: expected identifier or '('
     180 |     link->priv = NULL;
         |         ^
   drivers/parport/parport_cs.c:181:2: error: expected identifier or '('
     181 |         return -ENODEV;
         |         ^
   fatal error: too many errors emitted, stopping now [-ferror-limit=]
   1 warning and 20 errors generated.


vim +/failed +148 drivers/parport/parport_cs.c

84e2d34004dcd0 Dominik Brodowski 2008-07-29  134  
15b99ac1729503 Dominik Brodowski 2006-03-31  135  static int parport_config(struct pcmcia_device *link)
^1da177e4c3f41 Linus Torvalds    2005-04-16  136  {
^1da177e4c3f41 Linus Torvalds    2005-04-16  137      parport_info_t *info = link->priv;
^1da177e4c3f41 Linus Torvalds    2005-04-16  138      struct parport *p;
9b44de2015ff4a Dominik Brodowski 2009-10-24  139      int ret;
^1da177e4c3f41 Linus Torvalds    2005-04-16  140  
9b44de2015ff4a Dominik Brodowski 2009-10-24  141      dev_dbg(&link->dev, "parport_config\n");
^1da177e4c3f41 Linus Torvalds    2005-04-16  142  
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  143      if (epp_mode)
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  144  	    link->config_index |= FORCE_EPP_MODE;
00990e7ce0b0e5 Dominik Brodowski 2010-07-30  145  
9b44de2015ff4a Dominik Brodowski 2009-10-24  146      ret = pcmcia_loop_config(link, parport_config_check, NULL);
9b44de2015ff4a Dominik Brodowski 2009-10-24  147      if (ret)
84e2d34004dcd0 Dominik Brodowski 2008-07-29 @148  	    goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  149  
eb14120f743d29 Dominik Brodowski 2010-03-07  150      if (!link->irq)
9b44de2015ff4a Dominik Brodowski 2009-10-24  151  	    goto failed;
1ac71e5a35eebe Dominik Brodowski 2010-07-29  152      ret = pcmcia_enable_device(link);
9b44de2015ff4a Dominik Brodowski 2009-10-24  153      if (ret)
9b44de2015ff4a Dominik Brodowski 2009-10-24  154  	    goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  155  
9a017a910346af Dominik Brodowski 2010-07-24  156      p = parport_pc_probe_port(link->resource[0]->start,
9a017a910346af Dominik Brodowski 2010-07-24  157  			      link->resource[1]->start,
eb14120f743d29 Dominik Brodowski 2010-03-07  158  			      link->irq, PARPORT_DMA_NONE,
51dcdfec6a274a Alan Cox          2009-04-07  159  			      &link->dev, IRQF_SHARED);
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  160      if (!p) {
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  161          dev_err(&link->dev,
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  162              "parport_pc_probe_port() failed at 0x%03x, irq %u\n",
decf26f6ec25da Joe Perches       2020-04-03  163              (unsigned int)link->resource[0]->start, link->irq);
^1da177e4c3f41 Linus Torvalds    2005-04-16  164          goto failed;
^1da177e4c3f41 Linus Torvalds    2005-04-16  165      }   
^1da177e4c3f41 Linus Torvalds    2005-04-16  166  
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  167      }
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  168  
^1da177e4c3f41 Linus Torvalds    2005-04-16 @169      p->modes |= PARPORT_MODE_PCSPP;
^1da177e4c3f41 Linus Torvalds    2005-04-16  170      if (epp_mode)
^1da177e4c3f41 Linus Torvalds    2005-04-16  171  	p->modes |= PARPORT_MODE_TRISTATE | PARPORT_MODE_EPP;
^1da177e4c3f41 Linus Torvalds    2005-04-16 @172      info->ndev = 1;
^1da177e4c3f41 Linus Torvalds    2005-04-16  173      info->port = p;
^1da177e4c3f41 Linus Torvalds    2005-04-16  174  
15b99ac1729503 Dominik Brodowski 2006-03-31  175      return 0;
^1da177e4c3f41 Linus Torvalds    2005-04-16  176  
^1da177e4c3f41 Linus Torvalds    2005-04-16 @177  failed:
^1da177e4c3f41 Linus Torvalds    2005-04-16 @178  	parport_cs_release(link);
21c75ad65f8e52 YueHaibing        2019-03-21 @179  	kfree(link->priv);
fac3d7d7b11c82 Biancaa Ramesh    2025-10-22  180      link->priv = NULL;
15b99ac1729503 Dominik Brodowski 2006-03-31  181  	return -ENODEV;
^1da177e4c3f41 Linus Torvalds    2005-04-16  182  } /* parport_config */
^1da177e4c3f41 Linus Torvalds    2005-04-16  183  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

Powered by blists - more mailing lists

Powered by Openwall GNU/*/Linux Powered by OpenVZ