linux-kernel - Re: [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <904ba70f-b1bf-4745-8e92-d27a6c903673@kernel.org>
Date: Wed, 22 Oct 2025 22:56:14 +0200
From: Danilo Krummrich <dakr@...nel.org>
To: Mohamed Ahmed <mohamedahmedegypt2001@...il.com>
Cc: linux-kernel@...r.kernel.org, dri-devel@...ts.freedesktop.org,
 Mary Guillemard <mary@...y.zone>,
 Faith Ekstrand <faith.ekstrand@...labora.com>, Lyude Paul
 <lyude@...hat.com>, Maarten Lankhorst <maarten.lankhorst@...ux.intel.com>,
 Maxime Ripard <mripard@...nel.org>, Thomas Zimmermann <tzimmermann@...e.de>,
 David Airlie <airlied@...il.com>, Simona Vetter <simona@...ll.ch>,
 nouveau@...ts.freedesktop.org
Subject: Re: [PATCH 2/5] drm/nouveau/uvmm: Allow larger pages

On 10/22/25 12:16 PM, Mohamed Ahmed wrote:
> Pinging again re: review and also was asking if we can revert the
> select_page_shift() handling back to v1 behavior with a fall-back
> path, as it looks like there are some cases where
> nouveau_bo_fixup_align() isn't enough;
> https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/36450#note_3159199.

I don't think we should add a fallback for something that is expected to be
sufficient.

Instead we should figure out in which exact case the WARN_ON() was hit and why.