linux-kernel - Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <965a6f1f-37de-4029-ba16-cfd2de7895ed@riscstar.com>
Date: Tue, 21 Oct 2025 23:30:37 -0500
From: Alex Elder <elder@...cstar.com>
To: Troy Mitchell <troy.mitchell@...ux.spacemit.com>,
 Lee Jones <lee@...nel.org>, Yixun Lan <dlan@...too.org>
Cc: linux-kernel@...r.kernel.org, linux-riscv@...ts.infradead.org,
 spacemit@...ts.linux.dev, kernel test robot <lkp@...el.com>
Subject: Re: [PATCH] mfd: simple-mfd-i2c: remove select I2C_K1

On 10/21/25 8:58 PM, Troy Mitchell wrote:
> select will force a symbol to a specific value without considering
> its dependencies. As a result, the i2c-k1 driver will fail to build
> when OF or COMMON_CLK are disabled.

Should config I2C_K1 depend on COMMON_CLK then?

But you're right, the selecting config should ensure the
dependencies of the selected one are satisfied.

> The reason for removing I2C_K1 instead of adding a depends on condition
> is to keep the possibility for other SoCs to use this PMIC.

Acked-by: Alex Elder <elder@...cstar.com>

> 
> Reported-by: kernel test robot <lkp@...el.com>
> Closes: https://lore.kernel.org/oe-kbuild-all/202510211523.sSEVqPUQ-lkp@intel.com/
> Signed-off-by: Troy Mitchell <troy.mitchell@...ux.spacemit.com>
> ---
>   drivers/mfd/Kconfig | 1 -
>   1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/mfd/Kconfig b/drivers/mfd/Kconfig
> index 6cec1858947bf7ab5ee78beb730c95dabcb43a98..ea367c7e97f116d7585411fff5ba6bcd36882524 100644
> --- a/drivers/mfd/Kconfig
> +++ b/drivers/mfd/Kconfig
> @@ -1258,7 +1258,6 @@ config MFD_SPACEMIT_P1
>   	tristate "SpacemiT P1 PMIC"
>   	depends on ARCH_SPACEMIT || COMPILE_TEST
>   	depends on I2C
> -	select I2C_K1
>   	select MFD_SIMPLE_MFD_I2C
>   	help
>   	  This option supports the I2C-based SpacemiT P1 PMIC, which
> 
> ---
> base-commit: 3a8660878839faadb4f1a6dd72c3179c1df56787
> change-id: 20251021-p1-kconfig-fix-6d2b59d03b8f
> 
> Best regards,