linux-kernel - Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs for lan8814

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <4041a6f5-2033-47f8-9e33-69d7a5b3de04@engleder-embedded.com>
Date: Wed, 22 Oct 2025 06:12:22 +0200
From: Gerhard Engleder <gerhard@...leder-embedded.com>
To: Jakub Kicinski <kuba@...nel.org>
Cc: Horatiu Vultur <horatiu.vultur@...rochip.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org, andrew@...n.ch, hkallweit1@...il.com,
 linux@...linux.org.uk, davem@...emloft.net, edumazet@...gle.com,
 pabeni@...hat.com, richardcochran@...il.com
Subject: Re: [PATCH net-next] net: phy: micrel: Add support for non PTP SKUs
 for lan8814

On 22.10.25 01:14, Jakub Kicinski wrote:
> On Mon, 20 Oct 2025 20:11:13 +0200 Gerhard Engleder wrote:
>>>> Hasn't net also switched to the common kernel multiline comment style
>>>> starting with an empty line?
>>>
>>> I am not sure because I can see some previous commits where people used
>>> the same comment style:
>>> e82c64be9b45 ("net: stmmac: avoid PHY speed change when configuring MTU")
>>> 100dfa74cad9 ("net: dev_queue_xmit() llist adoption")
>>
>> The special coding style for multi line comments for net and drivers/net
>> has been removed with
>> 82b8000c28 ("net: drop special comment style")
>>
>> But I checked a few mails on the list and also found the old style in
>> new patches.
> 
> We removed the check that _suggests_ the use of the superior style.
> Aesthetic taste is not evenly distributed within the population.
> But we still prefer the old style in netdev.
> 
> That said I don't think nit picking on comment style is productive,
> in either direction.

I already had to remove the superior style on netdev. That's why I
commented it here. But I also like the old style more. Thank you for
the clarification!

Gerhard